From: Joe Buck <jbuck@synopsys.com>
To: nickc@cygnus.com (Nick Clifton)
Cc: koch@cognex.com, egcs@cygnus.com
Subject: Re: Should warnings be issued for unrecognised pragmas ?
Date: Sat, 18 Oct 1997 12:56:00 -0000 [thread overview]
Message-ID: <199710181955.MAA05705@atrus.synopsys.com> (raw)
In-Reply-To: <199710172208.PAA29771@elmo.cygnus.com>
> And how much is too much. Personally I suspect that most programmers
> only use -Wall occaisionally to see how their source is fairing,
No, I use -Wall all the time on every build, so do many programmers.
When I take over someone else's code who was less careful, -Wall usually
finds a bug or two.
> because they are already overwhelmed by the number of warnings it
> produces, especially if they have inherited some code from somebody
> else.
It's worth fixing the warnings.
Because large numbers of people use -Wall all the time on every build,
no warning should be added to -Wall that cannot be suppressed without
making the code worse. Since it's easy to supress compiler-specific
pragmas belonging to other compilers with #ifdef __Green_Hills__ or
the like, I don't care in this case whether -Wall objects or not.
So -Wunrecognized_pragmas could be in -Wall. On the other hand,
some of the "Effective C++" warnings can't be suppressed without
making some classes needlessly larger, so they can't be in -Wall.
next prev parent reply other threads:[~1997-10-18 12:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-10-16 16:07 Nick Clifton
1997-10-17 2:31 ` Andreas Schwab
1997-10-17 14:36 ` Donald Koch
1997-10-17 15:05 ` Nick Clifton
1997-10-17 15:06 ` Donald Koch
1997-10-17 15:06 ` Nick Clifton
1997-10-18 12:56 ` Joe Buck [this message]
1997-10-20 10:32 ` Nick Clifton
1997-10-20 10:43 ` Joe Buck
1997-10-20 10:49 ` Nick Clifton
1997-10-20 13:24 ` Joe Buck
1997-10-17 13:57 meissner
1997-10-17 14:36 ` Nick Clifton
1997-10-17 14:36 ` Joe Buck
1997-10-17 15:05 ` Nick Clifton
1997-10-17 19:44 ` Joe Buck
1997-10-19 5:54 ` Dave Love
1997-10-18 3:04 ` Richard Earnshaw
1997-10-17 15:06 ` Nick Clifton
1997-10-17 15:51 Mike Stump
1997-10-17 19:44 James L. Dein
1997-10-20 10:32 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199710181955.MAA05705@atrus.synopsys.com \
--to=jbuck@synopsys.com \
--cc=egcs@cygnus.com \
--cc=koch@cognex.com \
--cc=nickc@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).