* Dwarf EH bug in dwarf2out.c
@ 1997-10-31 20:50 H.J. Lu
1997-10-31 23:36 ` Jeffrey A Law
1997-11-01 0:41 ` Robert Lipe
0 siblings, 2 replies; 3+ messages in thread
From: H.J. Lu @ 1997-10-31 20:50 UTC (permalink / raw)
To: egcs
Hi,
dwarf2out.c uses ASM_OUTPUT_ASCII to output "eh",
.ascii "eh"
in asm code, which is not '\0' terminated. But frame.c assumes it
is and use strcmp/strlen on it. It doesn't work at all.
--
H.J. Lu (hjl@gnu.ai.mit.edu)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Dwarf EH bug in dwarf2out.c
1997-10-31 20:50 Dwarf EH bug in dwarf2out.c H.J. Lu
@ 1997-10-31 23:36 ` Jeffrey A Law
1997-11-01 0:41 ` Robert Lipe
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey A Law @ 1997-10-31 23:36 UTC (permalink / raw)
To: H.J. Lu; +Cc: egcs
In message < m0xRVWI-0004ecC@ocean.lucon.org >you write:
> Hi,
>
> dwarf2out.c uses ASM_OUTPUT_ASCII to output "eh",
>
> .ascii "eh"
>
> in asm code, which is not '\0' terminated. But frame.c assumes it
> is and use strcmp/strlen on it. It doesn't work at all.
Just wonderful. The comment before ASM_OUTPUT_DWARF_STRING is wrong
(claims it is just ASM_OUTPUT_ASCII without the trailing newline).
No big deal. Easy to fix.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Dwarf EH bug in dwarf2out.c
1997-10-31 20:50 Dwarf EH bug in dwarf2out.c H.J. Lu
1997-10-31 23:36 ` Jeffrey A Law
@ 1997-11-01 0:41 ` Robert Lipe
1 sibling, 0 replies; 3+ messages in thread
From: Robert Lipe @ 1997-11-01 0:41 UTC (permalink / raw)
To: H.J. Lu; +Cc: egcs
> dwarf2out.c uses ASM_OUTPUT_ASCII to output "eh",
>
> .ascii "eh"
>
> in asm code, which is not '\0' terminated. But frame.c assumes it
> is and use strcmp/strlen on it. It doesn't work at all.
Bummer. That sent my target down in flames, too.
This patch seems to make it work better.
*** dwarf2out.c_ Sat Nov 1 00:49:11 1997
--- dwarf2out.c Sat Nov 1 02:35:27 1997
***************
*** 1567,1573 ****
}
else
{
! ASM_OUTPUT_ASCII (asm_out_file, "eh", 2);
}
fputc ('\n', asm_out_file);
--- 1567,1573 ----
}
else
{
! ASM_OUTPUT_DWARF_STRING (asm_out_file, "eh");
}
fputc ('\n', asm_out_file);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1997-11-01 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-10-31 20:50 Dwarf EH bug in dwarf2out.c H.J. Lu
1997-10-31 23:36 ` Jeffrey A Law
1997-11-01 0:41 ` Robert Lipe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).