From: Richard Henderson <rth@cygnus.com>
To: egcs@cygnus.com
Cc: Robert Lipe <robertl@dgii.com>, jcardoso@inescn.pt, scox@cygnus.com
Subject: Re: f77 on sco5 fails on GOTOFF references
Date: Fri, 09 Jan 1998 00:57:00 -0000 [thread overview]
Message-ID: <19980109005815.21508@dot.cygnus.com> (raw)
In-Reply-To: <19971231150445.51268@dot.cygnus.com>
On Wed, Dec 31, 1997 at 03:04:45PM -0800, Richard Henderson wrote:
> I believe the problem to be between LEGITIMATE_PIC_OPERAND_P and the
> pushl "i" constraint, and the fact that the i386 backend lies to gcc
> about how pic really works. If the later were fixed (big overhaul),
> I'm sure many things would work much better.
I still believe that hiding the use of %ebx from the compiler for
constant pool addresses is wrong, but I did not have the patience
to walk through all of the lossage when turning that on.
However, here's a hacky patch that works for the test case
subroutine foo(a)
double precision a
a = dlog10(2.0d0)
return
end
I've no idea if a similar change is required elsewhere as well.
r~
Fri Jan 9 00:48:09 1998 Richard Henderson <rth@cygnus.com>
* i386.md (push): Delete identical !TARGET_MOVE pattern. Add
patterns to prohibit symbolic constants if flag_pic.
Index: i386.md
===================================================================
RCS file: /cvs/cvsfiles/egcs/gcc/config/i386/i386.md,v
retrieving revision 1.4
diff -u -p -d -r1.4 i386.md
--- i386.md 1997/11/05 19:29:37 1.4
+++ i386.md 1998/01/09 08:45:36
@@ -835,7 +835,13 @@
(define_insn ""
[(set (match_operand:SI 0 "push_operand" "=<")
(match_operand:SI 1 "general_operand" "g"))]
- "TARGET_PUSH_MEMORY"
+ "TARGET_PUSH_MEMORY && !flag_pic"
+ "push%L0 %1")
+
+(define_insn ""
+ [(set (match_operand:SI 0 "push_operand" "=<")
+ (match_operand:SI 1 "general_operand" "rmn"))]
+ "TARGET_PUSH_MEMORY && flag_pic"
"push%L0 %1")
;; If not a 386, it is faster to move MEM to a REG and then push, rather than
@@ -844,13 +850,13 @@
(define_insn ""
[(set (match_operand:SI 0 "push_operand" "=<")
(match_operand:SI 1 "nonmemory_operand" "ri"))]
- "!TARGET_PUSH_MEMORY && TARGET_MOVE"
+ "!TARGET_PUSH_MEMORY && !flag_pic"
"push%L0 %1")
(define_insn ""
[(set (match_operand:SI 0 "push_operand" "=<")
- (match_operand:SI 1 "nonmemory_operand" "ri"))]
- "!TARGET_PUSH_MEMORY && !TARGET_MOVE"
+ (match_operand:SI 1 "nonmemory_operand" "rn"))]
+ "!TARGET_PUSH_MEMORY && flag_pic"
"push%L0 %1")
;; General case of fullword move.
next prev parent reply other threads:[~1998-01-09 0:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-12-29 22:49 Robert Lipe
1997-12-30 1:29 ` Richard Henderson
1997-12-30 8:53 ` Robert Lipe
1997-12-30 17:43 ` John Carr
1997-12-31 0:08 ` Robert Lipe
1997-12-31 16:50 ` Richard Henderson
1997-12-31 20:11 ` Robert Lipe
1998-01-01 11:31 ` Dave Love
1998-01-09 0:57 ` Richard Henderson [this message]
1998-01-09 9:22 ` Robert Lipe
1998-01-11 13:22 ` Joao Cardoso
1998-01-11 13:22 ` Robert Lipe
1998-01-12 10:18 ` J. Kean Johnston
1998-01-09 12:09 ` Robert Lipe
1998-01-12 17:55 ` Dave Love
1998-01-19 2:25 ` whither fix for bogus x86 pushi? Robert Lipe
1998-01-20 2:21 ` Richard Henderson
1998-01-20 2:21 ` Robert Lipe
1998-01-19 23:51 ` Richard Henderson
1998-01-20 4:00 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19980109005815.21508@dot.cygnus.com \
--to=rth@cygnus.com \
--cc=egcs@cygnus.com \
--cc=jcardoso@inescn.pt \
--cc=robertl@dgii.com \
--cc=scox@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).