Re: another binutils-2.8.1 bug?

Re: another binutils-2.8.1 bug?

[H.J. Lu]

> 
> 
> 
> Yup, it's local.
> 
> Evidently, if you change a static function into a non-static function, 
> but the static prototype is left floating around, GCC converts the 
> function to a static automatically, which seems rather dangerous.
> 

I don't know what ANSI C says on it.

# gcc -S x.c -O 
x.c:4: conflicting types for `foo'
x.c:1: previous declaration of `foo'
----
	.file	"x.c"
	.version	"01.01"
/ GNU C version 2.8.0 (i586-unknown-linux-gnulibc1) compiled by GNU C version 2.8.0.
/ options passed:  -O
/ options enabled:  -fdefer-pop -fthread-jumps -fpeephole -ffunction-cse
/ -finline -fkeep-static-consts -fpcc-struct-return -fcommon -fverbose-asm
/ -fgnu-linker -m80387 -mhard-float -mno-soft-float -mieee-fp
/ -mfp-ret-in-387 -mschedule-prologue -mcpu=pentium -march=pentium

gcc2_compiled.:
.text
	.align 4
	.type	 foo,@function
foo:
	pushl %ebp
	movl %esp,%ebp
	movl %ebp,%esp
	popl %ebp
	ret
.Lfe1:
	.size	 foo,.Lfe1-foo
	.ident	"GCC: (GNU) 2.8.0"
---
static void foo ();

foo ()
{
}

Re: another binutils-2.8.1 bug?

[Paul Eggert]

   From: hjl@lucon.org (H.J. Lu)
   Date: Sat, 10 Jan 1998 13:45:43 -0800 (PST)

   > Evidently, if you change a static function into a non-static function, 
   > but the static prototype is left floating around, GCC converts the 
   > function to a static automatically, which seems rather dangerous.

   I don't know what ANSI C says on it.

ANSI C requires that behavior.

It might be nice if GCC warned about the situation, but I don't think
it's dangerous all that often.  All that happens is that the function
is unexpectedly static, which normally just leads to a link error.