public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Simons <msimons@saic1.com>
To: ghazi@caip.rutgers.edu (Kaveh R. Ghazi)
Cc: egcs@cygnus.com
Subject: Re: egcs-980129, warning patches to alpha.c
Date: Fri, 06 Feb 1998 00:57:00 -0000	[thread overview]
Message-ID: <199802060804.DAA22841@aura.saic1.com> (raw)
In-Reply-To: <199802052207.RAA21462@caip.rutgers.edu>

> Thu Feb  5 14:53:05 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
>  
>         (add_long_const): Use HOST_WIDE_INT_PRINT_DEC as needed.
[...]
> @@ -3246,7 +3273,9 @@
>    if (sa_size != 0)
>      {
>        reg_mask |= 1 << REG_RA;
> -      fprintf (file, "\tstq $26,%d($%d)\n", reg_offset, sa_reg);
> +      fprintf (file, "\tstq $26,");
> +      fprintf (file, HOST_WIDE_INT_PRINT_DEC, reg_offset);
> +      fprintf (file, "($%d)\n", sa_reg);
>        reg_offset += 8;
>        int_reg_save_area_size += 8;
>      }

Kaveh,

I just glanced at your patch, couldn't we do this:
  fprintf (file, "\tstq $26," HOST_WIDE_INT_PRINT_DEC "($%d)\n", 
           reg_offset, sa_reg);

  it is much more condensed, the compiler will merge the strings for us.  =)

--

    Thanks,
      Mike Simons
      Science Applications International Corporation
      msimons@saic1.com                  703-925-5674

  reply	other threads:[~1998-02-06  0:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-02-05 17:44 Kaveh R. Ghazi
1998-02-06  0:57 ` Mike Simons [this message]
1998-02-06  3:01   ` Andreas Schwab
1998-02-06  3:14   ` Olivier Galibert
1998-02-06  5:56   ` Manfred.Hollstein
1998-02-06  5:56 ` John Carr
1998-02-09  1:37 ` Jeffrey A Law
1998-02-06 17:06 Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199802060804.DAA22841@aura.saic1.com \
    --to=msimons@saic1.com \
    --cc=egcs@cygnus.com \
    --cc=ghazi@caip.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).