From: Richard Henderson <rth@cygnus.com>
To: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
Cc: egcs@cygnus.com
Subject: Re: egcs-980129, fixed ambiguous `else' warnings in the gcc/f/ dir.
Date: Thu, 12 Feb 1998 02:36:00 -0000 [thread overview]
Message-ID: <19980212011618.42585@dot.cygnus.com> (raw)
In-Reply-To: <199802112157.QAA27162@caip.rutgers.edu>
On Wed, Feb 11, 1998 at 04:57:39PM -0500, Kaveh R. Ghazi wrote:
> +++ egcs-980129/gcc/f/expr.c Tue Feb 3 15:50:59 1998
> @@ -8761,10 +8761,12 @@
> else
> { /* The normal stuff. */
> if (nbt == lbt)
> - if (nbt == rbt)
> - nkt = ffeinfo_kindtype_max (nbt, lkt, rkt);
> - else
> - nkt = lkt;
> + {
> + if (nbt == rbt)
> + nkt = ffeinfo_kindtype_max (nbt, lkt, rkt);
> + else
> + nkt = lkt;
> + }
> else if (nbt == rbt)
> nkt = rkt;
> else
It would be my preference that the pieces of the patch like this,
in which the if-then-else tree is full, _not_ be installed. This
will remind us that we should fix the bug in the warning code.
r~
next prev parent reply other threads:[~1998-02-12 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-02-11 18:20 Kaveh R. Ghazi
1998-02-12 2:36 ` Richard Henderson [this message]
1998-02-13 2:28 ` Jeffrey A Law
1998-02-13 2:04 ` Richard Henderson
1998-02-13 2:04 ` Jeffrey A Law
[not found] ` <19980212011618.42585.cygnus.egcs@dot.cygnus.com>
1998-02-12 19:36 ` Jason Merrill
1998-02-13 2:04 ` Jeffrey A Law
1998-02-12 20:07 Kaveh R. Ghazi
1998-02-13 10:31 ` Bernd Schmidt
1998-02-12 20:07 Kaveh R. Ghazi
1998-02-12 20:07 ` Richard Henderson
1998-02-13 2:04 ` Jeffrey A Law
1998-02-13 2:28 ` Andreas Schwab
1998-02-13 10:58 Kaveh R. Ghazi
1998-02-16 4:57 ` Bernd Schmidt
1998-02-17 23:59 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19980212011618.42585@dot.cygnus.com \
--to=rth@cygnus.com \
--cc=egcs@cygnus.com \
--cc=ghazi@caip.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).