public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joern Rennecke <amylaar@cygnus.co.uk>
To: law@cygnus.com, wilson@cygnus.com
Cc: egcs@cygnus.com
Subject: patch for update_flow_info REG_WAS_0
Date: Thu, 12 Feb 1998 18:02:00 -0000	[thread overview]
Message-ID: <199802130030.AAA24740@phal.cygnus.co.uk> (raw)

update_flow_info tried in vain to find the new setter for a (mem:DI ...
value after this was split into two memory accesses...

Fri Feb 13 00:25:02 1998  J"orn Rennecke <amylaar@cygnus.co.uk>

	* sched.c (update_flow_info, REG_WAS_0): Ignore if setting insn
	was deleted.

Index: sched.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gcc/sched.c,v
retrieving revision 1.120
diff -p -r1.120 sched.c
*** sched.c	1998/02/06 08:35:42	1.120
--- sched.c	1998/02/13 00:28:12
***************
*** 1,5 ****
  /* Instruction scheduling pass.
!    Copyright (C) 1992, 93-96, 1997 Free Software Foundation, Inc.
     Contributed by Michael Tiemann (tiemann@cygnus.com)
     Enhanced by, and currently maintained by, Jim Wilson (wilson@cygnus.com)
  
--- 1,5 ----
  /* Instruction scheduling pass.
!    Copyright (C) 1992, 93-97, 1998 Free Software Foundation, Inc.
     Contributed by Michael Tiemann (tiemann@cygnus.com)
     Enhanced by, and currently maintained by, Jim Wilson (wilson@cygnus.com)
  
*************** update_flow_info (notes, first, last, or
*** 3854,3859 ****
--- 3854,3867 ----
  	  break;
  
  	case REG_WAS_0:
+ 	  /* If the insn that set the register to 0 was deleted, this
+ 	     note cannot be relied on any longer.  The destination might
+ 	     even have been moved to memory.
+              This was observed for SH4 with execute/920501-6.c compilation,
+ 	     -O2 -fomit-frame-pointer -finline-functions .  */
+ 	  if (GET_CODE (XEXP (note, 0)) == NOTE
+ 	      || INSN_DELETED_P (XEXP (note, 0)))
+ 	    break;
  	  /* This note applies to the dest of the original insn.  Find the
  	     first new insn that now has the same dest, and move the note
  	     there.  */

             reply	other threads:[~1998-02-12 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-02-12 18:02 Joern Rennecke [this message]
1998-02-13  2:04 ` Jeffrey A Law
1998-02-13  2:16   ` Joern Rennecke
1998-02-13 10:31     ` Jeffrey A Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199802130030.AAA24740@phal.cygnus.co.uk \
    --to=amylaar@cygnus.co.uk \
    --cc=egcs@cygnus.com \
    --cc=law@cygnus.com \
    --cc=wilson@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).