From: Martin von Loewis <martin@mira.isdn.cs.tu-berlin.de>
To: egcs@cygnus.com
Subject: Bug in coerce_template_parms
Date: Sun, 15 Mar 1998 15:15:00 -0000 [thread overview]
Message-ID: <199803152249.XAA31126@mira.isdn.cs.tu-berlin.de> (raw)
Did anybody notice problems in template parameter resolution?
There seems to be a problem in coerce_template_parms, exposed e.g.
by ttp26.C. Around line 1896, it checks whether the arglist is
a vector. If it isn't, it treats it as a list.
Now, there is another check whether nargs==nparms. In ttp26.C, this is
not the case because there are default parameters. So the check
fails, but the arguments are still passed as a vector. This goes
unnoticed, as the code retrieves the argument using TREE_VALUE, which
happens to be the right offset. I'm sure one can construct examples
where the code breaks, though.
I found this by putting an assertion into TREE_VALUE that the node
really is a TREE_LIST. I don't have a test case for this specific
code. If nobody can reproduce the problem, I can try to find one. For
ttp26.C, the problem manifests in the 20th invocation of
coerce_template_parms.
Thanks,
Martin
next reply other threads:[~1998-03-15 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-15 15:15 Martin von Loewis [this message]
1998-03-16 20:44 ` Bug in coerce_template_parms (patch) Kriang Lerdsuwanakij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199803152249.XAA31126@mira.isdn.cs.tu-berlin.de \
--to=martin@mira.isdn.cs.tu-berlin.de \
--cc=egcs@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).