public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* egcs-980315, WARNING fixes part 2 (minor addition)
@ 1998-03-17  8:42 Kaveh R. Ghazi
  1998-03-18 16:14 ` Jim Wilson
  0 siblings, 1 reply; 4+ messages in thread
From: Kaveh R. Ghazi @ 1998-03-17  8:42 UTC (permalink / raw)
  To: egcs; +Cc: ghazi

	Here is another small warning fix.  It is okay to install?

		--Kaveh



Mon Mar 16 22:32:01 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

	* final.c (shorten_branches): Add parentheses around +/- in
	operand of &.

	* flow.c (life_analysis): Wrap variable `i' in macro ELIMINABLE_REGS.


diff -rup orig/egcs-980315/gcc/final.c egcs-980315/gcc/final.c
--- orig/egcs-980315/gcc/final.c	Mon Mar 16 22:21:15 1998
+++ egcs-980315/gcc/final.c	Mon Mar 16 22:11:56 1998
@@ -1165,7 +1165,7 @@ shorten_branches (first)
 	  if (log)
 	    {
 	      int align = 1 << log;
-	      int new_address = insn_current_address + align - 1 & -align;
+	      int new_address = (insn_current_address + align - 1) & -align;
 	      insn_lengths[uid] = new_address - insn_current_address;
 	      insn_current_address = new_address;
 	    }
@@ -1268,7 +1268,7 @@ shorten_branches (first)
 	      if (log > insn_current_align)
 		{
 		  int align = 1 << log;
-		  int new_address= insn_current_address + align - 1 & -align;
+		  int new_address= (insn_current_address + align - 1) & -align;
 		  insn_lengths[uid] = new_address - insn_current_address;
 		  insn_current_align = log;
 		  insn_current_address = new_address;
diff -rup orig/egcs-980315/gcc/flow.c egcs-980315/gcc/flow.c
--- orig/egcs-980315/gcc/flow.c	Mon Mar 16 22:21:59 1998
+++ egcs-980315/gcc/flow.c	Mon Mar 16 22:13:53 1998
@@ -961,7 +961,9 @@ life_analysis (f, nregs, file)
      int nregs;
      FILE *file;
 {
+#ifdef ELIMINABLE_REGS
   register size_t i;
+#endif
 
 #ifdef ELIMINABLE_REGS
   static struct {int from, to; } eliminables[] = ELIMINABLE_REGS;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: egcs-980315, WARNING fixes part 2 (minor addition)
  1998-03-17  8:42 egcs-980315, WARNING fixes part 2 (minor addition) Kaveh R. Ghazi
@ 1998-03-18 16:14 ` Jim Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Jim Wilson @ 1998-03-18 16:14 UTC (permalink / raw)
  To: Kaveh R. Ghazi; +Cc: egcs

This is OK to install.

Jim

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: egcs-980315, WARNING fixes part 2 (minor addition)
@ 1998-03-19 21:47 Kaveh R. Ghazi
  1998-03-19 15:36 ` Jim Wilson
  0 siblings, 1 reply; 4+ messages in thread
From: Kaveh R. Ghazi @ 1998-03-19 21:47 UTC (permalink / raw)
  To: wilson; +Cc: egcs

 > From: Jim Wilson <wilson@cygnus.com>
 > Subject: Re: egcs-980315, WARNING fixes part 2 (minor addition) 
 > 
 > This is OK to install.
 > Jim

	Done, (slightly modified to follow Robert's suggestion below,
hope that's ok.) 

		--Kaveh


 > From: Robert Lipe <robertl@dgii.com>
 > To: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
 > Subject: Re: egcs-980315, WARNING fixes part 2 (minor addition)
 > References: < 199803171537.KAA10985@caip.rutgers.edu >
 > Mime-Version: 1.0
 > Content-Type: text/plain; charset=us-ascii
 > X-Mailer: Mutt 0.89
 > In-Reply-To: < 199803171537.KAA10985@caip.rutgers.edu >; from Kaveh R. Ghazi on Tue, Mar 17, 1998 at 10:37:06AM -0500
 > Status: RO
 >  
 > > diff -rup orig/egcs-980315/gcc/flow.c egcs-980315/gcc/flow.c
 > > --- orig/egcs-980315/gcc/flow.c       Mon Mar 16 22:21:59 1998
 > > +++ egcs-980315/gcc/flow.c    Mon Mar 16 22:13:53 1998
 > > @@ -961,7 +961,9 @@ life_analysis (f, nregs, file)
 > >       int nregs;
 > >       FILE *file;
 > >  {
 > > +#ifdef ELIMINABLE_REGS
 > >    register size_t i;
 > > +#endif
 > >  
 > >  #ifdef ELIMINABLE_REGS
 > >    static struct {int from, to; } eliminables[] = ELIMINABLE_REGS;
 >  
 > Can these just be smooshed together rather than having two consecutive
 > identical #ifdefs?
 >  
 > No justification necessary regardless of what you decide...
 > RJL
--
Kaveh R. Ghazi			Project Manager / Custom Development
ghazi@caip.rutgers.edu		Icon CMT Corp.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: egcs-980315, WARNING fixes part 2 (minor addition)
  1998-03-19 21:47 Kaveh R. Ghazi
@ 1998-03-19 15:36 ` Jim Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Jim Wilson @ 1998-03-19 15:36 UTC (permalink / raw)
  To: Kaveh R. Ghazi; +Cc: egcs

	Done, (slightly modified to follow Robert's suggestion below,
	hope that's ok.) 

yeah, no problem.  It is OK to fix something I missed like this.

Jim

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1998-03-19 21:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-03-17  8:42 egcs-980315, WARNING fixes part 2 (minor addition) Kaveh R. Ghazi
1998-03-18 16:14 ` Jim Wilson
1998-03-19 21:47 Kaveh R. Ghazi
1998-03-19 15:36 ` Jim Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).