From: Jim Wilson <wilson@cygnus.com>
To: Richard Henderson <rth@cygnus.com>
Cc: Richard Gorton <gorton@amt.tay1.dec.com>, egcs@cygnus.com
Subject: Re: My egcs patch for Alpha
Date: Tue, 24 Mar 1998 12:23:00 -0000 [thread overview]
Message-ID: <199803242016.MAA23063@rtl.cygnus.com> (raw)
In-Reply-To: <19980318164942.44278@dot.cygnus.com>
As an aside, can someone tell me why the test immediately above mine
tests to see if the new code is the same as the original pattern's
code?
I think the assumption here is that if the code is the same, then the recursive
make_compound_operation call didn't do anything, and hence there is nothing
new to substitute in.
Along the same lines, is there any point in my test for paradoxical
subreg?
I don't see any need for this test either.
+ PUT_MODE (tem, mode);
The patch looks OK to me, however, this PUT_MODE call looks unsafe. We must
be able to undo all changes if the result fails to match the md file, but we
can't undo a PUT_MODE. Hence this will fail if tem happens to be shared with
the original RTX for the insn. You should use gen_rtx_combine instead.
Jim
next prev parent reply other threads:[~1998-03-24 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9803171634.AA32425@liszt.amt.tay1.dec.com>
1998-03-18 22:03 ` Richard Henderson
1998-03-24 12:23 ` Jim Wilson [this message]
1998-03-27 15:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199803242016.MAA23063@rtl.cygnus.com \
--to=wilson@cygnus.com \
--cc=egcs@cygnus.com \
--cc=gorton@amt.tay1.dec.com \
--cc=rth@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).