public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: meissner@cygnus.com
Cc: egcs@cygnus.com, law@cygnus.com
Subject: Re: egcs-980315 powerpc-ibm-aix4.1.4.0 warning fixes ...
Date: Fri, 27 Mar 1998 15:18:00 -0000	[thread overview]
Message-ID: <199803261631.LAA09871@caip.rutgers.edu> (raw)

 > From: Jeffrey A Law <law@hurl.cygnus.com>
 > 
 > Don't you need to make sure system.h is included in rs6000.c so that
 > you get size_t via one of the standard system include files?

	Well, it turns out that on AIX4, stdio.h declares size_t.  (I of
course did test the patch to make sure it bootstrapped) but you're right
that including system.h is safer. 


 > From: Michael Meissner <meissner@cygnus.com>
 > 
 > The part of rs6000.h that adds the declaration for:
 >  
 > extern enum direction function_arg_padding ();
 >  
 > is wrong, since it depends on the compiler supporting unknown tags to
 > enums, which is a GCC extension.  I have fixed this by making the
 > function an integer function.  I also included system.h as Jeff
 > pointed out and committed the fixes (including collect2.c and
 > dbxout.c).

	Hmm, when I did the bootstrap test I used cc for stage1, so
maybe AIX4 cc supports it too? But in any case, your solution makes for
more portable code.  So thanks for making the corrections and for
commiting the patch.  :-)

	One thing I noticed is that in adding system.h, you left in some
OS headers which duplicate stuff brought in by system.h.  This patch
fixes it, would you please consider it too?

		Thanks,
		--Kaveh

--- rs6000.c~	Thu Mar 26 11:27:30 1998
+++ rs6000.c	Thu Mar 26 11:27:55 1998
@@ -19,8 +19,6 @@
 the Free Software Foundation, 59 Temple Place - Suite 330,
 Boston, MA 02111-1307, USA.  */
 
-#include <stdio.h>
-#include <ctype.h>
 #include "config.h"
 #include "system.h"
 #include "rtl.h"


--
Kaveh R. Ghazi			Project Manager / Custom Development
ghazi@caip.rutgers.edu		Icon CMT Corp.

             reply	other threads:[~1998-03-27 15:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-03-27 15:18 Kaveh R. Ghazi [this message]
1998-03-31  0:46 ` Jeffrey A Law
  -- strict thread matches above, loose matches on Subject: below --
1998-03-25 14:00 Kaveh R. Ghazi
1998-03-25 17:22 ` Michael Meissner
1998-03-19 21:47 Kaveh R. Ghazi
1998-03-23 22:59 ` Jeffrey A Law
1998-03-24 10:24   ` David Edelsohn
1998-03-25 17:05     ` Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199803261631.LAA09871@caip.rutgers.edu \
    --to=ghazi@caip.rutgers.edu \
    --cc=egcs@cygnus.com \
    --cc=law@cygnus.com \
    --cc=meissner@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).