From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: law@cygnus.com
Cc: egcs@cygnus.com, wilson@cygnus.com
Subject: Re: egcs, more system.h cutover patches
Date: Mon, 30 Mar 1998 16:18:00 -0000 [thread overview]
Message-ID: <199803302033.PAA18252@caip.rutgers.edu> (raw)
> From: Jeffrey A Law <law@hurl.cygnus.com>
> >
> > Sat Mar 28 21:27:02 1998 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * Makefile.in (choose-temp.o, cppalloc.o, cpperror.o, cppexp.o,
> > cpphash.o, cpplib.o, cppmain.o, fix-header.o, gcov.o,
> > gen-protos.o, gengenrtl.o, halfpic.o, hash.o, scan-decls.o,
> > scan.o): Depend on system.h.
> >
> > * choose-temp.c: Include system.h. Add parameters to various
> > function prototypes.
> > * cppalloc.c: Likewise.
> > * cpperror.c: Likewise.
> > * cppexp.c: Likewise.
> > * cpphash.c: Likewise.
> > * cpplib.c: Likewise.
> > * cppmain.c: Likewise.
> > * fix-header.c: Likewise.
> > * gcov.c: Likewise.
> > * gen-protos.c: Likewise.
> > * gengenrtl.c: Likewise.
> > * halfpic.c: Likewise.
> > * hash.c: Likewise.
> > * scan-decls.c: Likewise.
> > * scan.c: Likewise.
> Looks mostly OK.
>
> Note that choose-temp.c needs to be kept sync'd with the copy in
> libiberty, so I think you need to change both copies at the same
> time (and make sure that it still works in libiberty :-)
>
> You added an include of config.h to cpphash.c, you need to make
> sure that's noted in the ChangeLog.
>
> Also don't mess with the xmalloc, xrealloc, xfree prototypes yet.
> That's an issue I want to revisit later (and fix them all at the
> same time).
>
> jeff
Okay, I installed it without choose-temp.c, added config.h ->
cpphash.c in the ChangeLog and took out the xmalloc, etc, prototype
argument additions.
I'll put in choose-temp.c shortly when I have time to examine
and sync with the copy in libiberty.
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu Icon CMT Corp.
next reply other threads:[~1998-03-30 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-30 16:18 Kaveh R. Ghazi [this message]
1998-03-31 0:46 Kaveh R. Ghazi
1998-03-31 0:20 ` Jeffrey A Law
1998-04-02 11:32 Kaveh R. Ghazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199803302033.PAA18252@caip.rutgers.edu \
--to=ghazi@caip.rutgers.edu \
--cc=egcs@cygnus.com \
--cc=law@cygnus.com \
--cc=wilson@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).