From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: egcs@cygnus.com, law@cygnus.com
Cc: ghazi@caip.rutgers.edu
Subject: Re:  system.h & warnings
Date: Thu, 02 Apr 1998 08:21:00 -0000
Message-id: <199804021620.LAA18789@caip.rutgers.edu>
X-SW-Source: 1998-04/msg00042.html

 > From: Jeffrey A Law <law@cygnus.com>
 > 
 > I've converted the insn*.c generated files to use system.h.
 > 
 > I've also tweaked genoutput.c so that the generated insn-output.c
 > does not give warnings about unused parameters.  This kills a couple
 > hundred warnings on the PA.
 > 
 > If these changes cause any problems, let me know ASAP.
 > 
 > Thanks,
 > jeff

	Great stuff!

	One thing I'd like to bring up, the test you used in genoutput.c
to see if __attribute__ should be used only checks __GNUC__.  This can
fail for stage1 compilers which are gcc but are older versions.  E.g. 
these can be either gcc installed by the user or the default compiler
(like maybe nextstep? I'll bet it fails there.)

	I'd like to put something in gansidecl.h to do a rigorous test
once.  Then one can use __attribute__, or macros based on it, more freely. 

	Should I make a patch to put the following in gansidecl.h?

		--Kaveh

 > #if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 7)
 > # define __attribute__(x)
 > #endif
 > 
 > #define ATTRIBUTE_UNUSED __attribute__ ((unused))
 > 
 > #define ATTRIBUTE_PRINTF(m, n) __attribute__ ((format (__printf__, m, n)))
 > #define ATTRIBUTE_PRINTF_1 ATTRIBUTE_PRINTF(1, 2)
 > #define ATTRIBUTE_PRINTF_2 ATTRIBUTE_PRINTF(2, 3)
 > #define ATTRIBUTE_PRINTF_3 ATTRIBUTE_PRINTF(3, 4)
--
Kaveh R. Ghazi			Project Manager / Custom Development
ghazi@caip.rutgers.edu		Icon CMT Corp.