Re: egcs, does gcc fixincludes etc guarantee a stdlib.h exists?

["Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>]

 > From: Jeffrey A Law <law@hurl.cygnus.com>
 > 
 >   In message < 199804010732.XAA09115@cygnus.com >you write:
 >   > >  > 	Simple question.  Does gcc guarantee that after it diddles with
 >   > >  > the system headers that a stdlib.h exists in some form?
 >   > > I do not believe that is the case.
 >   > 
 >   > Gcc *does* guarantee that after it diddles with the system headers
 >   > that a stdlib.h exists in some form.
 >   > 
 >   > This is handled by fixproto, which is normally run after fixincludes.
 > 
 > I stand corrected.  Obviously, I'm not all that familiar with the
 > actions of fixproto :-)
 > 
 > jeff


	Okay, I looked in fixproto and it looks as if it makes sure that
both stdlib.h and unistd.h exist.  Therefore, I would like to submit the
following patch to clean up warnings in target files frame.c and
libgcc2.c. 

	It is especially useful in cases where sizeof(int) != sizeof(void*).
This matters when, e.g malloc, because there is no prototype, is
implicitly declared returning int but it is cast and assigned to a
pointer.  I get the following warnings on mips-sgi-irix6.2, among
several others, which are cured by the patch below:

 > ./libgcc2.c: In function `__bb_init_prg':
 > ./libgcc2.c:2096: warning: cast to pointer from integer of different size
 > ./libgcc2.c:2103: warning: cast to pointer from integer of different size
 > ./libgcc2.c:2107: warning: cast to pointer from integer of different size
 > ./libgcc2.c:2117: warning: cast to pointer from integer of different size
 > ./libgcc2.c:2144: warning: cast to pointer from integer of different size
 > ./libgcc2.c:2152: warning: cast to pointer from integer of different size
 > ./libgcc2.c: In function `__bb_trace_func':
 > ./libgcc2.c:2204: warning: cast to pointer from integer of different size
 > ./libgcc2.c: In function `__bb_trace_func_ret':
 > ./libgcc2.c:2267: warning: cast to pointer from integer of different size
 > ./libgcc2.c: In function `__bb_init_file':
 > ./libgcc2.c:2313: warning: cast to pointer from integer of different size
 > ./libgcc2.c: In function `__bb_init_trace_func':
 > ./libgcc2.c:2387: warning: cast to pointer from integer of different size


		--Kaveh







Mon Apr 13 12:18:31 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 
        * frame.c: Include stdlib.h and unistd.h to possibly get various
        function prototypes.  The fixproto script guarantees these header
        files exist on the target system.
        * libgcc2.c: Likewise.
 
        * gthr-single.h (__gthread_mutex_lock, __gthread_mutex_trylock,
        __gthread_mutex_unlock): Add __attribute__ ((__unused__)) to the
        function parameters.
        * libgcc2.c (__udiv_w_sdiv): Likewise.


diff -rup orig/egcs-980406/gcc/frame.c egcs-980406/gcc/frame.c
--- orig/egcs-980406/gcc/frame.c	Fri Apr  3 11:34:56 1998
+++ egcs-980406/gcc/frame.c	Sat Apr 11 15:12:27 1998
@@ -32,6 +32,11 @@ Boston, MA 02111-1307, USA.  */
    do not apply.  */
 
 #include "tconfig.h"
+
+/* fixproto guarantees these system headers exist. */
+#include <stdlib.h>
+#include <unistd.h>
+
 #include "defaults.h"
 
 #ifdef DWARF2_UNWIND_INFO
diff -rup orig/egcs-980406/gcc/gthr-single.h egcs-980406/gcc/gthr-single.h
--- orig/egcs-980406/gcc/gthr-single.h	Fri Apr  3 11:35:40 1998
+++ egcs-980406/gcc/gthr-single.h	Sat Apr 11 15:23:36 1998
@@ -42,19 +42,19 @@ __gthread_active_p ()
 }
 
 static inline int
-__gthread_mutex_lock (__gthread_mutex_t *mutex)
+__gthread_mutex_lock (__gthread_mutex_t *mutex __attribute__ ((__unused__)))
 {
   return 0;
 }
 
 static inline int
-__gthread_mutex_trylock (__gthread_mutex_t *mutex)
+__gthread_mutex_trylock (__gthread_mutex_t *mutex __attribute__ ((__unused__)))
 {
   return 0;
 }
 
 static inline int
-__gthread_mutex_unlock (__gthread_mutex_t *mutex)
+__gthread_mutex_unlock (__gthread_mutex_t *mutex __attribute__ ((__unused__)))
 {
   return 0;
 }
diff -rup orig/egcs-980406/gcc/libgcc2.c egcs-980406/gcc/libgcc2.c
--- orig/egcs-980406/gcc/libgcc2.c	Sat Apr  4 12:38:13 1998
+++ egcs-980406/gcc/libgcc2.c	Sat Apr 11 15:15:44 1998
@@ -31,6 +31,11 @@ Boston, MA 02111-1307, USA.  */
    do not apply.  */
 
 #include "tconfig.h"
+
+/* fixproto guarantees these system headers exist. */
+#include <stdlib.h>
+#include <unistd.h>
+
 #include "machmode.h"
 #include "defaults.h" 
 #ifndef L_trampoline
@@ -391,7 +396,10 @@ __udiv_w_sdiv (USItype *rp, USItype a1, 
 #else
 /* If sdiv_qrnnd doesn't exist, define dummy __udiv_w_sdiv.  */
 USItype
-__udiv_w_sdiv (USItype *rp, USItype a1, USItype a0, USItype d)
+__udiv_w_sdiv (USItype *rp __attribute__ ((__unused__)),
+	       USItype a1 __attribute__ ((__unused__)),
+	       USItype a0 __attribute__ ((__unused__)),
+	       USItype d __attribute__ ((__unused__)))
 {
   return 0;
 }