From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Wood To: rouaix@my-dejanews.com (Marc Rouaix) Cc: egcs@cygnus.com (egcs@cygnus.com) Subject: Re: suggest parentheses around assignment used as truth value Date: Thu, 02 Jul 1998 07:08:00 -0000 Message-id: <199807011250.OAA00754@jolan.ppro> References: X-SW-Source: 1998-07/msg00085.html | I'd just like to register my opiniont that code like | | if (x = p()) {...} | | shouldn't generate a warning under gcc -Wall. Even if | you feel that code like this is obscure, the recommended | | if ((x = p())) {...} | | is just bizarre. | | --- | Marc It is a very common mistake to type '=' where '==' was intended. Using extra parentheses is a very logical way to make the code more clear in what you mean. Not only for the author itself, but also for others that read the code later and wonder if this is a typo/bug, or if it was intended (something not always clear from the context). My personal opinion is that this warning is so useful that I'd even object to move it to -pedantic warnings. -- Carlo Wood