public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: untested changes (was re: patch applied to reload1.c)
       [not found] <199809252355.QAA31273@dm.cobaltmicro.com>
@ 1998-09-25 19:21 ` Joern Rennecke
  0 siblings, 0 replies; only message in thread
From: Joern Rennecke @ 1998-09-25 19:21 UTC (permalink / raw)
  To: David S. Miller; +Cc: egcs

>    Thanks.  However, the coding standards say to avoid assignments inside
>    conditions, so reverted the code to use a separate assignment.
> 
> Thats sort of hypocritcal considering how the rest of reload (and
> actually, most of the entire compiler) does this everywhere.

This usually happens where the assignment needs to be guarded by
some preliminary checks, so there is no easy way to convert this code.

If you find places where assignments are placed in if conditions for
no good reason, consider submitting a patch.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1998-09-25 19:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <199809252355.QAA31273@dm.cobaltmicro.com>
1998-09-25 19:21 ` untested changes (was re: patch applied to reload1.c) Joern Rennecke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).