From mboxrd@z Thu Jan 1 00:00:00 1970 From: Donn Terry To: Richard Henderson Cc: "egcs@egcs.cygnus.com" Subject: Re: ISO C violation (really -- style & string pasting) Date: Wed, 31 Mar 1999 23:46:00 -0000 Message-ID: <36FAC4F0.157DA22@interix.com> References: <36F9848A.9F566D1A@interix.com> <19990325142948.E27147@cygnus.com> <36FABD09.CC8997F6@interix.com> <19990325150718.A27839@cygnus.com> X-SW-Source: 1999-03n/msg00837.html Message-ID: <19990331234600.vn8oNw6rRrUmMpjtSygg4rgadA6a3NOWT717rdfbJt4@z> I certainly can do that, but it's not going to be a neat surgical strike, as the changes spread themselves across a lot of places. If a change of that nature is going to be (in principle) acceptable, then I'll do it (it may be a bit before I do). Donn Richard Henderson wrote: > > On Thu, Mar 25, 1999 at 03:47:37PM -0700, Donn Terry wrote: > > i386.c: output_asm_insn ("addl $_GLOBAL_OFFSET_TABLE_,%0", xops); > > These references should be converted into proper arguments. > Create a SYMBOL_REF with the GLOBAL_OFFSET_TABLE_SYMBOL and > put it in xops as needed. > > > i386.c: output_asm_insn ("addl $_GLOBAL_OFFSET_TABLE_+[.-%P1],%0", xops); > > This one should probably be converted to > > (const:SI (plus:SI (symbol_ref:SI GLOBAL_OFFSET_TABLE_SYMBOL) > (minus:SI (pc) > (symbol_ref:SI FOO)))) > > and teach print_operand any missing bits so that > > output_asm_insn ("addl %P1,%0", xops); > > will do the right thing. > > r~ -- =================================================== Donn Terry mailto:donn@interix.com Softway Systems, Inc. http://www.interix.com 2850 McClelland Dr, Ste. 1800 Ft.Collins CO 80525 Tel: +1-970-204-9900 Fax: +1-970-204-9951 ===================================================