From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zack Weinberg To: craig@jcb-sc.com Cc: hjl@lucon.com, egcs@egcs.cygnus.com Subject: Re: egcs-1.2 stuff Date: Mon, 12 Apr 1999 10:34:00 -0000 Message-id: <199904121733.NAA17287@blastula.phys.columbia.edu> References: <19990412171642.1629.qmail@deer> X-SW-Source: 1999-04/msg00419.html On 12 Apr 1999 17:16:42 -0000, craig@jcb-sc.com wrote: >>BTW, what happened to my patch to libf2c/Makefile.in: >> >>Fri Jan 15 07:06:25 1999 H.J. Lu (hjl@gnu.org) >> >> * Makefile.in (FLAGS_TO_PASS): Use "" instead of ''. >> >>I need it to add >> >>RUNTESTFLAGS=--tool_opts '-mcpu=pentiumpro -march=pentiumpro' >> >>and >> >>RUNTESTFLAGS=--tool_opts '-mcpu=pentiumpro -march=pentiumpro -fPIC' >> >>to the top level Makefile. It is useful to run testsuites for PPro and >>PIC. Does anyone else run testsuites for PPro on libf2c? I have >>complained about libf2c many times. Does anyone from libf2c really have >>time to listen and care? > >It's in my queue, from back when you complained about this for the Nth >time. [...] >Of course, I welcome anyone who *already* understands those things >stepping in and saying "here's the *right* way to do stuff like this", >but that hasn't happened yet, AFAIK. It's a consistency issue. All the other Makefiles have FLAGS_TO_PASS defined like so: FLAGS_TO_PASS = CC="$(CC)" BISON="$(BISON)" ... but libf2c has FLAGS_TO_PASS = CC='$(CC)' BISON='$(BISON)' ... Therefore, you can't use "" or '' quotes in any of the FLAGS_TO_PASS variables. If libf2c used "" quotes, it would be safe to put '' quotes into FLAGS_TO_PASS variables. I don't have HJ's patch to look at, but if it does just what the ChangeLog says it does, I think it's the Right Thing. This is yet another way the build framework is too complicated. zw From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zack Weinberg To: craig@jcb-sc.com Cc: hjl@lucon.com, egcs@egcs.cygnus.com Subject: Re: egcs-1.2 stuff Date: Fri, 30 Apr 1999 23:15:00 -0000 Message-ID: <199904121733.NAA17287@blastula.phys.columbia.edu> References: <19990412171642.1629.qmail@deer> X-SW-Source: 1999-04n/msg00422.html Message-ID: <19990430231500.W21GKxDjLpB8H5otnWXVtPvg18cHuO37qtPjjll4yKA@z> On 12 Apr 1999 17:16:42 -0000, craig@jcb-sc.com wrote: >>BTW, what happened to my patch to libf2c/Makefile.in: >> >>Fri Jan 15 07:06:25 1999 H.J. Lu (hjl@gnu.org) >> >> * Makefile.in (FLAGS_TO_PASS): Use "" instead of ''. >> >>I need it to add >> >>RUNTESTFLAGS=--tool_opts '-mcpu=pentiumpro -march=pentiumpro' >> >>and >> >>RUNTESTFLAGS=--tool_opts '-mcpu=pentiumpro -march=pentiumpro -fPIC' >> >>to the top level Makefile. It is useful to run testsuites for PPro and >>PIC. Does anyone else run testsuites for PPro on libf2c? I have >>complained about libf2c many times. Does anyone from libf2c really have >>time to listen and care? > >It's in my queue, from back when you complained about this for the Nth >time. [...] >Of course, I welcome anyone who *already* understands those things >stepping in and saying "here's the *right* way to do stuff like this", >but that hasn't happened yet, AFAIK. It's a consistency issue. All the other Makefiles have FLAGS_TO_PASS defined like so: FLAGS_TO_PASS = CC="$(CC)" BISON="$(BISON)" ... but libf2c has FLAGS_TO_PASS = CC='$(CC)' BISON='$(BISON)' ... Therefore, you can't use "" or '' quotes in any of the FLAGS_TO_PASS variables. If libf2c used "" quotes, it would be safe to put '' quotes into FLAGS_TO_PASS variables. I don't have HJ's patch to look at, but if it does just what the ChangeLog says it does, I think it's the Right Thing. This is yet another way the build framework is too complicated. zw