Re: Annoying warning

[Joe Buck <jbuck@Synopsys.COM>]

> This code snippet, from the STL:
> 
> inline int __black_count(__rb_tree_node_base* node, __rb_tree_node_base* root)
> {
    [ a recursive function ]
> }
> 
> causes this warning when compiled with -g -O3 :
> 
> /usr/local/egcs/include/g++/stl_tree.h:1045: warning: can't inline call to `int __black_count(struct __rb_tree_node_base *, struct __rb_tree_node_base *)'
> /usr/local/egcs/include/g++/stl_tree.h:1053: warning: called from here
> 
> Shouldn't this warning be suppressed for a recursive call?

No, the whole point of the warning is to report when an inline operation
can't be performed.

It would be better to either remove the 'inline' or to rewrite the
function into a form that can be inlined (tail recursion):

inline int __black_count(__rb_tree_node_base* node, __rb_tree_node_base* root,
			 int black_parent)
{
    if (node == 0)
	return black_parent;
    else {
        int bc = (node->color == __rb_tree_black);
	if (node == root)
	    return bc + black_parent;
	else
	    return __black_count(node->parent, root, bc);
    }
}

inline int __black_count(__rb_tree_node_base* node, __rb_tree_node_base* root)
{
    return __black_count(node, root, 0);
}