From mboxrd@z Thu Jan 1 00:00:00 1970 From: Per Bothner To: Mark Klein Cc: egcs@egcs.cygnus.com, java-discuss@sourceware.cygnus.com Subject: Re: assemble_external on .class files Date: Mon, 31 May 1999 21:36:00 -0000 Message-ID: References: <4.1.19990525220502.00ca56a0@garfield.dis.com> X-SW-Source: 1999-05n/msg00718.html Message-ID: <19990531213600.PUTLEs9Xa_X_jStmF1funlS-KlNcDb9eBJzAY8e8rrA@z> Mark Klein writes: > Could be, but then there's a problem with assemble_external vis the usage of > DECL_EXTERNAL for the vtable. Recall my earlier example, from > java::lang::Object: Ah - that was in a message that had expired. My logic only applies to entries in the "method table". It is wrong for entries in the vtable. It is also wrong for calls to static methods in other classes. METHOD_NATIVE does need to be split from DECL_EXTERNAL. There doesn't seem to be any available DECL_LANG_FLAGs, but there are some TREE_LANG_FLAGSs available (in FUNCTION_DECLs). That means that we need to set DECL_EXTERNAL separately. I think it should be true for any methods that has METHOD_NATIVE, *or* if is_compiled_class (DECL_CONTEXT (method_decl)) < 2. --Per Bothner bothner@pacbell.net http://home.pacbell.net/bothner/