From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey A Law To: Mark Klein Cc: gcc@gcc.gnu.org Subject: Re: MPE Port Date: Sun, 31 Oct 1999 23:35:00 -0000 Message-ID: <14616.940915293@upchuck> References: <4.1.19990906102936.00c80c40@garfield.dis.com> X-SW-Source: 1999-10n/msg00625.html Message-ID: <19991031233500.0V4lRqWUtkMzX6Hg_7YDpiTpqLg0JEBfFRDGL4PUvWc@z> In message <4.1.19990906102936.00c80c40@garfield.dis.com>you write: > Sat Sep 4 18:00:00 PDT 1999 Mark Klein (mklein@dis.com) > > * libobjc/thr-dce.c (__objc_thread_set_priority): PRI_FG_MIN_NP is > not > available in all DCE ports. If not defined, return 0. > (__objc_thread_get_priority): If PRI_FG_MIN_NP not defined, default > to OBJC_THREAD_INTERACTIVE_PRIORITY. Seems to me that we can avoid #ifdefs in the actual funtions by providing a default value for PRI_FG_MIN_NP (and possibly others if they are not defined by your version of DCE threads). If possible it helps to avoid #ifdefing executable C code just from a readability standpoint. What happens if you provide a default value of zero for those priority values if they're not already defined? [ Nope, I haven't forgotten about this stuff :-) ] jeff