From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Klein To: law@cygnus.com Cc: gcc@gcc.gnu.org Subject: Re: MPE Port Date: Sun, 31 Oct 1999 23:35:00 -0000 Message-ID: <4.2.0.58.19991026064911.00c6ad40@garfield.dis.com> References: <4.1.19990906102936.00c80c40@garfield.dis.com> <14616.940915293@upchuck> X-SW-Source: 1999-10n/msg00642.html Message-ID: <19991031233500.DR1z2v2mu28aJqnDoDZGaTqb2Xeb_upgx5tIOaMPCcU@z> At 11:21 PM 10/25/99 -0600, Jeffrey A Law wrote: > In message <4.1.19990906102936.00c80c40@garfield.dis.com>you write: > > Sat Sep 4 18:00:00 PDT 1999 Mark Klein (mklein@dis.com) > > > > * libobjc/thr-dce.c (__objc_thread_set_priority): > PRI_FG_MIN_NP is > > not > > available in all DCE ports. If not defined, return 0. > > (__objc_thread_get_priority): If PRI_FG_MIN_NP not defined, default > > to OBJC_THREAD_INTERACTIVE_PRIORITY. >Seems to me that we can avoid #ifdefs in the actual funtions by providing >a default value for PRI_FG_MIN_NP (and possibly others if they are not >defined by your version of DCE threads). If possible it helps to avoid >#ifdefing executable C code just from a readability standpoint. > >What happens if you provide a default value of zero for those priority >values if they're not already defined? Actually, what's really missing is the pthread_setprio() call. That would also need to be provided as a dummy procedure too. At that point, it wouldn't matter what value were provided for PRI_FG_MIN_NP. (Note the _NP indicates a non-portable feature and shouldn't be relied upon outside of a specific platform). >[ Nope, I haven't forgotten about this stuff :-) ] No problem ... I'm busy too with my 'real' job. :-) Regards, M. -- Mark Klein DIS International, Ltd. http://www.dis.com 415-892-8400 PGP Public Key Available