* Adding ggc_free to htab_create_ggc macro?
@ 2004-03-26 12:52 Daniel Berlin
2004-03-26 15:39 ` Zack Weinberg
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Berlin @ 2004-03-26 12:52 UTC (permalink / raw)
To: gcc mailing list
Now that we have a ggc_free, should we use it in our htab_create_ggc
macro as the htab_free.
I'm not talking about the htab_delete function, I mean the last
argument, which controls what the table itself is allocated/freed what,
not the entries.
That would let the htab free the old ggc_alloc'd memory immediately
when it expands the table.
We use htab_create_ggc in quite a few places, so it seems like it might
be a win.
Has anyone benchmarked this change, and found it to be a loss, or was
this just not explored yet?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Adding ggc_free to htab_create_ggc macro?
2004-03-26 12:52 Adding ggc_free to htab_create_ggc macro? Daniel Berlin
@ 2004-03-26 15:39 ` Zack Weinberg
0 siblings, 0 replies; 2+ messages in thread
From: Zack Weinberg @ 2004-03-26 15:39 UTC (permalink / raw)
To: Daniel Berlin; +Cc: gcc mailing list
Daniel Berlin <dberlin@dberlin.org> writes:
> Now that we have a ggc_free, should we use it in our htab_create_ggc
> macro as the htab_free.
> I'm not talking about the htab_delete function, I mean the last
> argument, which controls what the table itself is allocated/freed
> what, not the entries.
> That would let the htab free the old ggc_alloc'd memory immediately
> when it expands the table.
> We use htab_create_ggc in quite a few places, so it seems like it
> might be a win.
> Has anyone benchmarked this change, and found it to be a loss, or was
> this just not explored yet?
Not explored yet.
zw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-26 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-26 12:52 Adding ggc_free to htab_create_ggc macro? Daniel Berlin
2004-03-26 15:39 ` Zack Weinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).