From: Alexander Monakov <amonakov@ispras.ru>
To: gcc@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: Separate warning/error thresholds for -Wfoo=<n>
Date: Tue, 6 Dec 2022 18:52:39 +0300 (MSK) [thread overview]
Message-ID: <1ba6f0dc-7683-5589-6f88-9f95cab48ed8@ispras.ru> (raw)
Greetings, David, community,
I'd like to get your input on how GCC command line interface should support
making a "tiered" warning like -Warray-bounds={1,2} an error for "tier 1"
where fewer false positives are expected, and a plain warning otherwise.
There was a recent thread mentioning the current limitation [1]:
> This also shows nicely why I don't like warnings with levels, what if I want
> -Werror=array-bounds=2 + -Warray-bounds=1?
Also in PR 48088 [2] there was a request to make it work for stack size usage:
> Stumbled on this bug today. I tried to use it in more intricate way:
>
> -Wframe-larger-than=4096 -Werror=frame-larger-than=32768
>
> which would only warn about any stack more than 4096+, but would fail on
> 32768+.
>
> Does it make sense to implement desired behaviour?
> I guess it's not many '>=number' style options in gcc.
A problem with implementing DWIM semantics like above for -Wfoo=k -Werror=foo=n
combination is that technically it changes its current meaning.
If we don't want to risk that, an alternative is to introduce a new option
for selecting error threshold for a tiered warning, for example:
-Warray-bounds=2 -Werror-level=array-bounds=1
Implementation-wise, we would need to extend common.opt language to annotate
which tier is more inclusive (generally smaller 'n' means fewer warnings, but
for -Wstack-usage and -Wstrict-aliasing it's the other way around).
Opinions? Does anybody envision problems with going the DWIM way?
Thanks.
Alexander
[1] https://inbox.sourceware.org/gcc-patches/2552ab22-916f-d0fe-2c78-d482f6ad8412@lauterbach.com/
[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48088#c5
next reply other threads:[~2022-12-06 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 15:52 Alexander Monakov [this message]
2022-12-06 16:18 ` Richard Biener
2022-12-06 16:43 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba6f0dc-7683-5589-6f88-9f95cab48ed8@ispras.ru \
--to=amonakov@ispras.ru \
--cc=dmalcolm@redhat.com \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).