From: Zack Weinberg <zack@wolery.cumb.org>
To: Joern Rennecke <amylaar@cygnus.co.uk>
Cc: gcc@gcc.gnu.org
Subject: Re: varasm patch breaks sh-coff
Date: Mon, 11 Sep 2000 11:25:00 -0000 [thread overview]
Message-ID: <20000911112542.B13727@wolery.cumb.org> (raw)
In-Reply-To: <200009111806.TAA21473@phal.cygnus.co.uk>
On Mon, Sep 11, 2000 at 07:06:49PM +0100, Joern Rennecke wrote:
> This patch:
[ * varasm.c (make_decl_rtl): Restore leading star on
DECL_ASSEMBLER_NAME set for decls with an asmspec.
]
> breaks sh-coff. In libgcc1-test.c, there is:
...
> Your patch causes "*start" to be used for the identifier.
> In sdbout.c:sdbout_symbol, the '*' is not stripped:
...
> PUT_SDB_DEF (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)));
PUT_SDB_DEF (and all the other macros in sdbout.c that use
ASM_OUTPUT_LABELREF) should be using assemble_name instead. sdbout.c
is the only place in the compiler that does _not_ use assemble_name
for this purpose.
I can't test sh-coff; can you do the patch, please?
zw
next prev parent reply other threads:[~2000-09-11 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-09-11 11:07 Joern Rennecke
2000-09-11 11:25 ` Zack Weinberg [this message]
2000-09-11 11:52 ` sdbout.c patch to use assemble_name (Was: Re: varasm patch breaks sh-coff) Joern Rennecke
2000-09-11 15:12 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000911112542.B13727@wolery.cumb.org \
--to=zack@wolery.cumb.org \
--cc=amylaar@cygnus.co.uk \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).