From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Booth To: Jamie Lokier Cc: Jan Dvorak , Craig Rodrigues , gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: warning: multi-line comment (why?) Date: Mon, 25 Sep 2000 14:10:00 -0000 Message-id: <20000925221004.A24101@daikokuya.demon.co.uk> References: <20000917185453.A14829@mediaone.net> <20000917162647.A19521@cygnus.com> <20000918120419.C17692@pcep-jamie.cern.ch> <20000919180308.A7018@napalm.go.cz> <20000919191221.A20462@pcep-jamie.cern.ch> <20000919214025.A30587@daikokuya.demon.co.uk> <20000919214320.A30677@daikokuya.demon.co.uk> <20000920175206.A31338@pcep-jamie.cern.ch> <20000920172728.A17616@daikokuya.demon.co.uk> <20000925215143.A16833@pcep-jamie.cern.ch> X-SW-Source: 2000-09/msg00622.html Jamie Lokier wrote:- > Neal, you're right my loop was broken with /\/. Please find > attached one patch and one test case. I don't have Dejagnu installed > but I've formatted the test case that way so you can give it a try. Hmm, you didn't read my mail did you? :-) You've not really fixed it, and made it hard work. What if there's two escaped newlines in a row? Or if there's a trigraphed backslash? get_effective_char handles all that for you, rather than you checking the result of a buffer->cur++. To be consistent we should also whitespace-skip \v and \f. No special tab handling is needed - it's only there to keep track of columns for warnings, and since we're a line comment there are not going to be any warnings on the line (trigraph warnings are now turned off). is_nvspace does all that for you. > If you like the patch I'll need to send in the copyright assignment > form. I'll do it myself properly soon, and that'll solve the copyright problem. I'll cc you when I do. I think we can use your test case without problems. Thanks, Neil.