From: Loren James Rittle <rittle@latour.rsch.comm.mot.com>
To: gcc@gcc.gnu.org
Subject: Re: commitinfo script to check policy, issue warnings (and/or abort commit)
Date: Fri, 18 May 2001 11:40:00 -0000 [thread overview]
Message-ID: <200105181840.f4IIebI90374@latour.rsch.comm.mot.com> (raw)
In-Reply-To: <or7kzhraiy.fsf@guarana.lsd.ic.unicamp.br>
In article < or7kzhraiy.fsf@guarana.lsd.ic.unicamp.br >, Alexandre Oliva <aoliva@redhat.com> writes:
> On May 14, 2001, Loren James Rittle <rittle@latour.rsch.comm.mot.com> wrote:
>> for i in `basename $1`; do case $i in
> basename is not portable. I suggest `echo "$1" | sed 's,.*/,,'' instead.
OK. Even though the code only runs on Red Hat servers - changed.
> I heard Hans wanted the GCC CVS tree to become the official repository
> of boehm-gc. I'm not sure this is already official.
OK. I think we can change the script as the situation is reported in
gcc@gcc.gnu.org.
>> if (exit $message_emitted); then
>> echo "WARNING: See http://gcc.gnu.org/codingconventions.html for details."
>> fi
> I don't think we should prevent commits, but if check-ins can be
> aborted at this time with ^C, I suggest telling the user so and giving
> him/her like 30 seconds to decide whether to break the convention or
> not.
This stuck me as a good idea. I have studied this issue a bit.
Informing the user they have 30 seconds to abort and then sleeping for
30 seconds does not work! If the user aborts, the abort is captured
by the local client and then 30 seconds after the procedure started,
the server proceeds to commit the change.
I also investigated halting the commitinfo script with a read. As
expected, there is no pipe back to the CVS client.
It looks like a passive warning system is the best I can do with
available resources.
Regards,
Loren
next prev parent reply other threads:[~2001-05-18 11:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-14 13:54 Loren James Rittle
2001-05-14 17:45 ` commitinfo script to check policy, issue warnings (and/orabort commit) Mark Mitchell
2001-05-16 0:57 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-16 1:31 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Gerald Pfeifer
2001-05-18 11:43 ` Loren James Rittle
2001-05-18 11:46 ` Loren James Rittle
2001-05-18 11:40 ` Loren James Rittle [this message]
2001-05-19 18:46 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-20 10:17 ` commitinfo script to check policy, issue warnings (and/orabort commit) Mark Mitchell
2001-05-24 6:15 ` Loren James Rittle
2001-05-16 1:38 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-18 11:49 ` Loren James Rittle
2001-05-18 12:58 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Joseph S. Myers
2001-05-18 13:24 ` Loren James Rittle
2001-05-16 6:38 ` Gerald Pfeifer
2001-05-16 9:24 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-18 12:14 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Loren James Rittle
2001-05-16 13:31 ` commitinfo script to check policy, issue warnings (and/or abort commit) Marc Espie
2001-05-16 15:12 ` Branko
2001-05-17 6:07 ` Marc Espie
2001-05-17 12:08 ` Branko
2001-05-17 20:18 ` Loren James Rittle
2001-05-17 22:22 ` Fergus Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105181840.f4IIebI90374@latour.rsch.comm.mot.com \
--to=rittle@latour.rsch.comm.mot.com \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).