From: Mark Mitchell <mark@codesourcery.com>
To: aoliva@redhat.com
Cc: rittle@labs.mot.com, gcc@gcc.gnu.org
Subject: Re: commitinfo script to check policy, issue warnings (and/orabort commit)
Date: Sun, 20 May 2001 10:17:00 -0000 [thread overview]
Message-ID: <20010520101145G.mitchell@codesourcery.com> (raw)
In-Reply-To: <oreltk7px5.fsf@guarana.lsd.ic.unicamp.br>
>>>>> "Alexandre" == Alexandre Oliva <aoliva@redhat.com> writes:
Alexandre> On May 18, 2001, Loren James Rittle
Alexandre> <rittle@latour.rsch.comm.mot.com> wrote:
>> Informing the user they have 30 seconds to abort and then
>> sleeping for 30 seconds does not work! If the user aborts, the
>> abort is captured by the local client and then 30 seconds after
>> the procedure started, the server proceeds to commit the
>> change.
Alexandre> :-(
Gentlemen --
In my opinion, we are working too hard to enforce this policy,
through what are probably relatively frail means. I think
notification is good enough. There are lots of other aspects of our
coding standards that are more important (like that functions have
comments, or that code be tested before check-in) that we rely
entirely on the honor system for.
If we're going to be in the business of writing complex scripts to
check things on check-in, I'd rather we be writing the
documentation-checker. I'm not joking actually -- use javadoc style
comments, maybe, and then make sure they're present.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com
next prev parent reply other threads:[~2001-05-20 10:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-14 13:54 commitinfo script to check policy, issue warnings (and/or abort commit) Loren James Rittle
2001-05-14 17:45 ` commitinfo script to check policy, issue warnings (and/orabort commit) Mark Mitchell
2001-05-16 0:57 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-16 1:31 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Gerald Pfeifer
2001-05-18 11:43 ` Loren James Rittle
2001-05-18 11:46 ` Loren James Rittle
2001-05-18 11:40 ` commitinfo script to check policy, issue warnings (and/or abort commit) Loren James Rittle
2001-05-19 18:46 ` Alexandre Oliva
2001-05-20 10:17 ` Mark Mitchell [this message]
2001-05-24 6:15 ` commitinfo script to check policy, issue warnings (and/orabort commit) Loren James Rittle
2001-05-16 1:38 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-18 11:49 ` Loren James Rittle
2001-05-18 12:58 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Joseph S. Myers
2001-05-18 13:24 ` Loren James Rittle
2001-05-16 6:38 ` Gerald Pfeifer
2001-05-16 9:24 ` commitinfo script to check policy, issue warnings (and/or abort commit) Alexandre Oliva
2001-05-18 12:14 ` commitinfo script to check policy, issue warnings (and/or abortcommit) Loren James Rittle
2001-05-16 13:31 ` commitinfo script to check policy, issue warnings (and/or abort commit) Marc Espie
2001-05-16 15:12 ` Branko
2001-05-17 6:07 ` Marc Espie
2001-05-17 12:08 ` Branko
2001-05-17 20:18 ` Loren James Rittle
2001-05-17 22:22 ` Fergus Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010520101145G.mitchell@codesourcery.com \
--to=mark@codesourcery.com \
--cc=aoliva@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=rittle@labs.mot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).