Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

[Jason Merrill]

>>>>> "Loren" == Loren James Rittle <rittle@latour.rsch.comm.mot.com> writes:

> In article <m3g0dfi5hx.fsf@prospero.cambridge.redhat.com> you write:
>> Shouldn't those all be void (*)(), not void *?

>>> ! static void *__gthread_active_ptr = (void *) &pthread_create;

> I don't think so.  No function calls are ever made through
> __gthread_active_ptr.

It's still wrong to use a pointer to data type to refer to a function.

> In other implementations of the gthr.h interface (e.g. win32),
> __gthread_active_ptr might map to a symbol known to exist in the
> threaded C library with value 1 and exist in the non-threaded C
> library with a value 0.

> Why it is type (void*) instead of int is unknown to me.

Perhaps it should be

  static int __gthread_active_ptr = !! &pthread_create;

then?

Jason

Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

[Loren James Rittle]

>> Why it is type (void*) instead of int is unknown to me.

> Perhaps it should be

>   static int __gthread_active_ptr = !! &pthread_create;

> then?

No disagreement from me.  However, changing the type of
__gthread_active_ptr is an ABI change instead of a mere bug fix to
allow C++ compilation of the header...

I am wiling to do more clean up on those files since I understand
them, but I didn't want to radically change anything.

Regards,
Loren

Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

[Jason Merrill]

>>>>> "Loren" == Loren James Rittle <rittle@latour.rsch.comm.mot.com> writes:

>>> Why it is type (void*) instead of int is unknown to me.

>> Perhaps it should be

>> static int __gthread_active_ptr = !! &pthread_create;

>> then?

> No disagreement from me.  However, changing the type of
> __gthread_active_ptr is an ABI change instead of a mere bug fix to
> allow C++ compilation of the header...

I suppose so.  Well,

   (void *) !! &pthread_create

would still be more correct...

Jason

Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

[Richard Henderson]

On Wed, Jun 06, 2001 at 12:43:20PM +0100, Jason Merrill wrote:
> Perhaps it should be
> 
>   static int __gthread_active_ptr = !! &pthread_create;
> 
> then?

That isn't valid C.  This file must be usable by both C and C++.


r~

Re: PATCH: Allow gcc/gthr* to be compiled by C++ as well as C

[Jason Merrill]

>>>>> "Richard" == Richard Henderson <rth@redhat.com> writes:

> On Wed, Jun 06, 2001 at 12:43:20PM +0100, Jason Merrill wrote:
>> Perhaps it should be
>> 
>> static int __gthread_active_ptr = !! &pthread_create;
>> 
>> then?

> That isn't valid C.  This file must be usable by both C and C++.

Good point.  OK, never mind...

Jason