public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joe Buck <jbuck@synopsys.COM>
To: gcc@gcc.gnu.org
Subject: patch tracking
Date: Fri, 14 Sep 2001 12:02:00 -0000	[thread overview]
Message-ID: <200109141902.MAA15299@atrus.synopsys.com> (raw)

The biggest problem facing GCC seems to be that patches aren't getting
reviewed.  I think it's a process problem; we don't have a system for
keeping track of patches, and the load on the people qualified to
approve patches is too high.  As a result, it's very difficult for
people without blanket write privs to effectively contribute to the
project; the turnaround for patch review can be months.  This means
we're not getting the problems fixed and the frustration level is high.

In thinking about what the ideal system should look like, I have the
following ideas (feel free to discard and come up with something better):

First, we want to decrease the number of patches that the overworked
experts must handle, by having a pre-screening process.  So, we have
a team of volunteers who have some experience but are not necessarily
gurus.  These folks would be the first screen for incoming patches.  They
would ask the following questions:

1) Are there papers on file for the patch submitter?  (The volunteers
would need to have a copy of the list to verify this).

(If not, ask submitter to file papers and resubmit the patch when
complete)

2) Does the patch follow the GNU coding guidelines?  If not, ask submitter
to revise.  (not worth nitpicking over extremely tiny violations here,
since this is not the final review)

3) Has the submitter indicated that the patch has been adequately
tested, and that the rules on http://gcc.gnu.org/contribute.html
have been followed?  If not, confirm, ask to resubmit.

4) Does the patch contain obvious bogosities?  If so, kick it back.

Note that these questions apply to code changes, not documentation
changes.  We may want to split off proposed patches to the manual
(that do not accompany code changes) or to the web site onto a separate
list that would run the way we do now, since we don't have the same
problems there. (gcc-doc-patches, say).

Next, we want to carefully track patches that pass the pre-screening
process to make sure that they get a timely review and are added if
appropriate.

If these tests are all passed, then the patch would enter a tracking
system.  Perhaps GNATS can be used, even though the patch is not exactly
a bug.  A new category proposed-patch can be created with the patch
as an attachment.  We can come up with conventions as to how to use
the severity and priority fields, we can keep track of what has been
analyzed, etc.

I realize that GNATS is not ideal for patch-tracking, but it's already
in place.

Thoughts?

Joe

             reply	other threads:[~2001-09-14 12:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-14 12:02 Joe Buck [this message]
2001-09-14 12:21 ` Diego Novillo
2001-09-14 12:24 ` egcs
2001-09-14 12:28 ` Joseph S. Myers
2001-09-14 12:35   ` Phil Edwards
2001-09-14 14:03 ` Zack Weinberg
2001-09-14 14:16   ` Phil Edwards
2001-09-14 14:51     ` Joe Buck
2001-09-14 15:53     ` Zack Weinberg
2001-09-14 14:53   ` Joe Buck
2001-09-14 15:48     ` Zack Weinberg
2001-09-14 14:24 ` Gerald Pfeifer
2001-09-15  3:07 ` Bernd Schmidt
2001-09-16 14:46   ` Joe Buck
2001-09-18 16:18     ` Marc Espie
2001-09-18  9:49 dewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200109141902.MAA15299@atrus.synopsys.com \
    --to=jbuck@synopsys.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).