From: Joe Buck <jbuck@synopsys.COM>
To: florian@edamail.fishkill.ibm.com (Florian Krohm)
Cc: zack@codesourcery.com (Zack Weinberg),
guillaume.thouvenin@polymtl.ca (Guillaume),
jbuck@synopsys.COM (Joe Buck),
gcc@gcc.gnu.org
Subject: Re: fdump-ast-original and strg:
Date: Fri, 23 Nov 2001 14:42:00 -0000 [thread overview]
Message-ID: <200111301901.LAA29450@atrus.synopsys.com> (raw)
In-Reply-To: <01113013544402.01459@warp9.fishkill.ibm.com> from "Florian Krohm" at Nov 30, 2001 01:54:44 PM
> > "\0122" will work fine. (Or, in this case, "\n2" assuming ASCII.)
> >
> Yup, you're right. So if you use octal notation to represent a
> non-printable character and always use 3 octal digits following
> the '\' you have something that should work in all cases.
>
> > We already have code to emit strings safely, into the assembly output;
> > you could just use that.
> >
> Even better!
Not just "even better", IMHO. While I'm not the one that will make
a decision about whether a patch is acceptable, I think that any patch
that includes a complete new conversion function should be rejected,
if the option of simply calling an existing string-emitting function
exists.
WARNING: multiple messages have this Message-ID
From: Joe Buck <jbuck@synopsys.COM>
To: florian@edamail.fishkill.ibm.com (Florian Krohm)
Cc: zack@codesourcery.com (Zack Weinberg),
guillaume.thouvenin@polymtl.ca (Guillaume),
jbuck@synopsys.COM (Joe Buck),
gcc@gcc.gnu.org
Subject: Re: fdump-ast-original and strg:
Date: Fri, 30 Nov 2001 11:01:00 -0000 [thread overview]
Message-ID: <200111301901.LAA29450@atrus.synopsys.com> (raw)
Message-ID: <20011130110100.kX7G9UlgiWDB-C4_B45MS66C1d1RJtduMuScaR4y99s@z> (raw)
In-Reply-To: <01113013544402.01459@warp9.fishkill.ibm.com>
> > "\0122" will work fine. (Or, in this case, "\n2" assuming ASCII.)
> >
> Yup, you're right. So if you use octal notation to represent a
> non-printable character and always use 3 octal digits following
> the '\' you have something that should work in all cases.
>
> > We already have code to emit strings safely, into the assembly output;
> > you could just use that.
> >
> Even better!
Not just "even better", IMHO. While I'm not the one that will make
a decision about whether a patch is acceptable, I think that any patch
that includes a complete new conversion function should be rejected,
if the option of simply calling an existing string-emitting function
exists.
next prev parent reply other threads:[~2001-11-30 19:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-22 13:14 Guillaume
2001-11-22 13:14 ` Joe Buck
2001-11-23 8:49 ` Guillaume
2001-11-23 8:52 ` Florian Krohm
2001-11-23 10:56 ` Joe Buck
2001-11-30 10:22 ` Joe Buck
2001-11-23 11:04 ` Dale Johannesen
2001-11-23 16:20 ` TImode ?inhibited? in main 3.1 branch davide.rossetti
2001-11-30 12:31 ` davide.rossetti
2001-11-23 17:46 ` fdump-ast-original and strg: Tim Hollebeek
2001-11-23 18:26 ` Dale Johannesen
2001-11-30 15:02 ` Dale Johannesen
2001-11-30 14:59 ` Tim Hollebeek
2001-11-30 10:24 ` Dale Johannesen
2001-11-23 11:14 ` Zack Weinberg
2001-11-23 14:13 ` Florian Krohm
2001-11-23 14:42 ` Joe Buck [this message]
2001-11-23 23:16 ` Richard Henderson
2001-11-24 3:30 ` Zack Weinberg
2001-11-24 3:38 ` Richard Henderson
2001-11-30 15:50 ` Richard Henderson
2001-11-30 15:37 ` Zack Weinberg
2001-11-30 15:28 ` Richard Henderson
2001-11-30 11:01 ` Joe Buck
2001-11-30 10:54 ` Florian Krohm
2001-11-23 16:40 ` Guillaume
2001-11-30 13:55 ` Guillaume
2001-11-30 10:26 ` Zack Weinberg
2001-11-30 10:12 ` Florian Krohm
2001-11-30 9:54 ` Guillaume
2001-11-29 19:00 ` Joe Buck
2001-11-29 18:46 ` Guillaume
2001-11-24 11:14 mike stump
2001-11-24 12:41 ` Joe Buck
2001-11-30 17:12 ` Joe Buck
2001-11-30 16:59 ` mike stump
2001-11-24 14:37 mike stump
2001-11-24 17:15 ` Joseph S. Myers
2001-11-30 18:35 ` Joseph S. Myers
2001-12-03 14:23 ` Richard Henderson
2001-11-30 17:49 ` mike stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200111301901.LAA29450@atrus.synopsys.com \
--to=jbuck@synopsys.com \
--cc=florian@edamail.fishkill.ibm.com \
--cc=gcc@gcc.gnu.org \
--cc=guillaume.thouvenin@polymtl.ca \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).