* submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake?
@ 2001-12-09 19:32 Adam Megacz
2001-12-09 23:58 ` Andreas Jaeger
2001-12-10 12:40 ` DJ Delorie
0 siblings, 2 replies; 3+ messages in thread
From: Adam Megacz @ 2001-12-09 19:32 UTC (permalink / raw)
To: gcc
When submitting a patch to a configure.in file, should the submitter
include diffs of the changes to other files (Makefile.in, etc), or
will the maintiner who commits it to cvs re-run
aclocal/autoconf/autoheader/automake before doing a cvs commit?
- a
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake?
2001-12-09 19:32 submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake? Adam Megacz
@ 2001-12-09 23:58 ` Andreas Jaeger
2001-12-10 12:40 ` DJ Delorie
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Jaeger @ 2001-12-09 23:58 UTC (permalink / raw)
To: Adam Megacz; +Cc: gcc
Adam Megacz <gcc@lists.megacz.com> writes:
> When submitting a patch to a configure.in file, should the submitter
> include diffs of the changes to other files (Makefile.in, etc), or
> will the maintiner who commits it to cvs re-run
> aclocal/autoconf/autoheader/automake before doing a cvs commit?
You don't commit them - but add in your ChangeLog entry that those
are regenerated and mention it in your email so that the committer
does it,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake?
2001-12-09 19:32 submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake? Adam Megacz
2001-12-09 23:58 ` Andreas Jaeger
@ 2001-12-10 12:40 ` DJ Delorie
1 sibling, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2001-12-10 12:40 UTC (permalink / raw)
To: gcc; +Cc: gcc
> When submitting a patch to a configure.in file, should the submitter
> include diffs of the changes to other files (Makefile.in, etc), or
> will the maintiner who commits it to cvs re-run
> aclocal/autoconf/autoheader/automake before doing a cvs commit?
When you post a patch to the mailing lists for approval, IMHO you
don't need to include diffs for the regenerated files. The reviewer
can regenerate them if they really want to know what the changes are.
However, *you* should look at those diffs, to make sure that you
aren't accidentally using the wrong version of the tools and thus are
causing unexpected unrelated changes to the generated files.
Of course, whoever checks in the .in files (you or the maintainer)
must check in freshly regenerated files that go along with it also.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-12-10 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-09 19:32 submitting patches to configure.in -- include results of aclocal/autoconf/autoheader/automake? Adam Megacz
2001-12-09 23:58 ` Andreas Jaeger
2001-12-10 12:40 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).