From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23031 invoked by alias); 24 Apr 2002 07:50:46 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 23003 invoked from network); 24 Apr 2002 07:50:42 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sources.redhat.com with SMTP; 24 Apr 2002 07:50:42 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 00DA14FC70; Wed, 24 Apr 2002 09:50:42 +0200 (CEST) Date: Wed, 24 Apr 2002 01:00:00 -0000 From: Jan Hubicka To: Jakub Jelinek Cc: Jan Hubicka , Michel LESPINASSE , Richard Henderson , gcc list Subject: Re: GCC performance regression - its memset ! Message-ID: <20020424075042.GG1887@atrey.karlin.mff.cuni.cz> References: <20020421005718.GA16378@zoy.org> <20020422213222.GA21429@zoy.org> <20020422165953.A32536@redhat.com> <20020423001045.GA26276@zoy.org> <20020423092540.GC27274@atrey.karlin.mff.cuni.cz> <20020423203526.GA1851@zoy.org> <20020424071748.GA1887@atrey.karlin.mff.cuni.cz> <20020424092958.Z32482@sunsite.ms.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020424092958.Z32482@sunsite.ms.mff.cuni.cz> User-Agent: Mutt/1.3.27i X-SW-Source: 2002-04/txt/msg01227.txt.bz2 > On Wed, Apr 24, 2002 at 09:17:48AM +0200, Jan Hubicka wrote: > > > instead of the more generic -mcpu=pentiumpro. Nice work guys ! I am > > > still worried though, that other people will have the same trouble > > > with inlining as I did and not see all of the performance improvements > > > as a result. > > > > I will send patch to increase the constant to 128. I was re-benchmarking > > the code and on P4/Athlon and my assembly memset, the 64 is just on the border > > (ie inlined/not inlined sollution have less than 10% difference), setting > > it to 128 does not make us to loose something. For glibc implementation > > 128 is still a win to be inlined :( > > So please contribute it to glibc then... > Is yours an Athlon optimized memset or does it perform better on P3/P4 too? It is fairly simple memset (for small cases only what matter is whether memset do have fast path trought), but I do have Athlon optimized as well. The problem with glibc is that it needs machinery for Athlon specific stuff and AFAIK glibc maintainers didn't decided how to do that. Honza > > Jakub