Passing -Wabi to all target libraries

Passing -Wabi to all target libraries

[Phil Edwards]

I worked up a patch to always build libstdc++ with -Wabi, and then thought
that perhaps all C++-using target libraries should have this on.  What are
people's thoughts on this?

The easiest way, I think, would be to pass it as part of the toplevel
configure.in's CXX_FOR_TARGET.


Phil

-- 
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                 - Edsger Dijkstra, 1930-2002

Re: Passing -Wabi to all target libraries

[Joe Buck]

> I worked up a patch to always build libstdc++ with -Wabi, and then thought
> that perhaps all C++-using target libraries should have this on.  What are
> people's thoughts on this?

Yes, it's a good idea.

Re: Passing -Wabi to all target libraries

[Phil Edwards]

On Thu, Aug 29, 2002 at 01:28:17PM -0700, Joe Buck wrote:
> 
> > I worked up a patch to always build libstdc++ with -Wabi, and then thought
> > that perhaps all C++-using target libraries should have this on.  What are
> > people's thoughts on this?
> 
> Yes, it's a good idea.

Someone else will have to do it.  I have been defeated by toplevel configury.

- Makefile.in sets and passes both CXXFLAGS_FOR_TARGET and
  LIBCXXFLAGS_FOR_TARGET, but in target libraries, sets CXXFLAGS to the
  first, not the second.  I don't know what the second variable is meant
  to be used for, given that it /isn't/ used even though all the targets
  are libraries.

- Adding -Wabi to CXXFLAGS_FOR_TARGET doesn't change anything, because the
  assignment on line 141 of Makefile.in is later overridden (not appended
  to) by a fragment inserted into the generated Makefile.  I don't know
  which fragment or where it comes from.  The variable is not documented as
  "this is substituted by configure," so this took a while to debug.


Phil

-- 
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                 - Edsger Dijkstra, 1930-2002