[basic-improvements] Massive SPEC2000 failures

[basic-improvements] Massive SPEC2000 failures

[Diego Novillo]

Starting on 2002-11-28 we have started failing to build a good
number of SPEC2000 tests with -march=pentium4: gzip, gcc, crafty,
parser, perlbmk, gap, bzip2, mesa and art.

We seem to be emitting bogus operands for cmovb and others.  An
example from 164.gzip:

-----------------------------------------------------------------------------
 /home/dnovillo/perf/sbox/bib/local/inst/lib/gcc-lib/i686-pc-linux-gnu/3.4-bi/cc1 -quiet -v -D__GNUC__=3 -D__GNUC_MINOR__=4 -D__GNUC_PATCHLEVEL__=0 trees.c -quiet -dumpbase trees.c -march=pentium4 -auxbase-strip trees.o -O2 -version -o /tmp/cchr6QFS.s
GNU C version 3.4-bi 20021115 (experimental) (i686-pc-linux-gnu)
        compiled by GNU C version 3.4-bi 20021115 (experimental).
ignoring nonexistent directory "/home/dnovillo/perf/sbox/bib/local/inst/i686-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /home/dnovillo/perf/sbox/bib/local/inst/include
 /home/dnovillo/perf/sbox/bib/local/inst/lib/gcc-lib/i686-pc-linux-gnu/3.4-bi/include
 /usr/include
End of search list.
 as -V -Qy -o trees.o /tmp/cchr6QFS.s
GNU assembler version 2.13 (i686-pc-linux-gnu) using BFD version 2.13 20021029
/tmp/cchr6QFS.s: Assembler messages:
/tmp/cchr6QFS.s:700: Error: suffix or operands invalid for `cmovb'
specmake: *** [trees.o] Error 1
-----------------------------------------------------------------------------

Jan, this looks like your doing :)

-----------------------------------------------------------------------------
diff -r -x CVS -dupN /notnfs/dnovillo/sbox/bib/gcc.prev/gcc/ChangeLog /notnfs/dnovillo/sbox/bib/gcc/gcc/ChangeLog
--- /notnfs/dnovillo/sbox/bib/gcc.prev/gcc/ChangeLog	Tue Nov 26 00:02:37 2002
+++ /notnfs/dnovillo/sbox/bib/gcc/gcc/ChangeLog	Thu Nov 28 00:02:27 2002
@@ -1,3 +1,45 @@
+Wed Nov 27 20:34:13 CET 2002  Jan Hubicka  <jh@suse.cz>
+
+	* i386.c (x86_sse_partial_regs_for_cvtsd2ss): New.
+	* i386.h (x86_sse_partial_regs_for_cvtsd2ss): Declare.
+	(TARGET_SSE_PARTIAL_REGS_FOR_CVTSD2SS): New macro.
+	* i386.md (truncdfsf patterns and splitters): Use
+	TARGET_SSE_PARTIAL_REGS_FOR_CVTSD2SS
+
+Tue Nov 26 22:43:50 CET 2002  Jan Hubicka  <jh@suse.cz>
+
+	* i386.c (ix86_expand_int_movcc):  Do not emit lea for short mode on
+	partial_reg_stall target.
+
+Tue Nov 26 22:27:47 CET 2002  Jan Hubicka  <jh@suse.cz>
+
+	* i386.md (movhicc): Allow general operand.
+	(movqicc): New expander.
+	(movqicc_noc): New pattern.
+	* i386.c (ix86_expand_carry_flag_compare): New function.
+	(ix86_expand_int_movcc): Optimize harder using sbb; support more
+	HImode conversion; support QImode conditional moves
+
+Tue Nov 26 16:30:59 CET 2002  Jan Hubicka  <jh@suse.cz>
+
+	* i386.c (FAST_PROLOGUE_INSN_COUNT): Set to 20.
+	(ix86_expand_prologue): Multiply the count by amount of registers to be
+	pushed.
+
+Tue Nov 26 15:55:27 CET 2002  Jan Hubicka  <jh@suse.cz>
+
+	* i386.c (override_options): Error about wrong -mcpu on x86-64
+	compilation.
-----------------------------------------------------------------------------

Re: [basic-improvements] Massive SPEC2000 failures

[Jan Hubicka]

> Starting on 2002-11-28 we have started failing to build a good
> number of SPEC2000 tests with -march=pentium4: gzip, gcc, crafty,
> parser, perlbmk, gap, bzip2, mesa and art.
> 
> We seem to be emitting bogus operands for cmovb and others.  An
> example from 164.gzip:
> 
> -----------------------------------------------------------------------------
>  /home/dnovillo/perf/sbox/bib/local/inst/lib/gcc-lib/i686-pc-linux-gnu/3.4-bi/cc1 -quiet -v -D__GNUC__=3 -D__GNUC_MINOR__=4 -D__GNUC_PATCHLEVEL__=0 trees.c -quiet -dumpbase trees.c -march=pentium4 -auxbase-strip trees.o -O2 -version -o /tmp/cchr6QFS.s
> GNU C version 3.4-bi 20021115 (experimental) (i686-pc-linux-gnu)
>         compiled by GNU C version 3.4-bi 20021115 (experimental).
> ignoring nonexistent directory "/home/dnovillo/perf/sbox/bib/local/inst/i686-pc-linux-gnu/include"
> #include "..." search starts here:
> #include <...> search starts here:
>  /usr/local/include
>  /home/dnovillo/perf/sbox/bib/local/inst/include
>  /home/dnovillo/perf/sbox/bib/local/inst/lib/gcc-lib/i686-pc-linux-gnu/3.4-bi/include
>  /usr/include
> End of search list.
>  as -V -Qy -o trees.o /tmp/cchr6QFS.s
> GNU assembler version 2.13 (i686-pc-linux-gnu) using BFD version 2.13 20021029
> /tmp/cchr6QFS.s: Assembler messages:
> /tmp/cchr6QFS.s:700: Error: suffix or operands invalid for `cmovb'
> specmake: *** [trees.o] Error 1
> -----------------------------------------------------------------------------
> 
> Jan, this looks like your doing :)

I will fix this shortly.  It works for -march=athlon as the cmov always
gets promoted to 32bit, but not for -march=pentium4 as we don't do the
promotion.  This is also bug, I will fix both.
Thanks!
Honza