public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* REG_FREQ
@ 2002-12-19 10:19 Zdenek Dvorak
  2002-12-19 16:43 ` REG_FREQ Jan Hubicka
  0 siblings, 1 reply; 3+ messages in thread
From: Zdenek Dvorak @ 2002-12-19 10:19 UTC (permalink / raw)
  To: gcc; +Cc: jh

Hello,

I have noticed that REG_FREQ is not zeroed anywhere; it means that
frequencies are just accumulating into it during multiple calls to
recompute_reg_usage. Is that intentional? I so, what is the rationale?

Zdenek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: REG_FREQ
  2002-12-19 10:19 REG_FREQ Zdenek Dvorak
@ 2002-12-19 16:43 ` Jan Hubicka
  2002-12-19 22:09   ` [PATCH] for REG_FREQ Zdenek Dvorak
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Hubicka @ 2002-12-19 16:43 UTC (permalink / raw)
  To: Zdenek Dvorak; +Cc: gcc, jh

> Hello,
> 
> I have noticed that REG_FREQ is not zeroed anywhere; it means that
> frequencies are just accumulating into it during multiple calls to
> recompute_reg_usage. Is that intentional? I so, what is the rationale?

No, it is not intentional nor rational.  Please just zero it out.
I wonder why it works quite well as it is :))

Honza
> 
> Zdenek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] for Re: REG_FREQ
  2002-12-19 16:43 ` REG_FREQ Jan Hubicka
@ 2002-12-19 22:09   ` Zdenek Dvorak
  0 siblings, 0 replies; 3+ messages in thread
From: Zdenek Dvorak @ 2002-12-19 22:09 UTC (permalink / raw)
  To: Jan Hubicka; +Cc: gcc, gcc-patches

Hello,

> > I have noticed that REG_FREQ is not zeroed anywhere; it means that
> > frequencies are just accumulating into it during multiple calls to
> > recompute_reg_usage. Is that intentional? I so, what is the rationale?
> 
> No, it is not intentional nor rational.  Please just zero it out.
> I wonder why it works quite well as it is :))

OK, commited as obvious.

Zdenek

Changelog:
   * flow.c (allocate_reg_life_data): Reset REG_FREQ.

Index: flow.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/flow.c,v
retrieving revision 1.542
diff -c -3 -p -r1.542 flow.c
*** flow.c	16 Dec 2002 18:19:27 -0000	1.542
--- flow.c	20 Dec 2002 00:48:49 -0000
*************** allocate_reg_life_data ()
*** 1529,1534 ****
--- 1529,1535 ----
        REG_N_DEATHS (i) = 0;
        REG_N_CALLS_CROSSED (i) = 0;
        REG_LIVE_LENGTH (i) = 0;
+       REG_FREQ (i) = 0;
        REG_BASIC_BLOCK (i) = REG_BLOCK_UNKNOWN;
      }
  }

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-12-20  1:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-19 10:19 REG_FREQ Zdenek Dvorak
2002-12-19 16:43 ` REG_FREQ Jan Hubicka
2002-12-19 22:09   ` [PATCH] for REG_FREQ Zdenek Dvorak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).