From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17237 invoked by alias); 30 Dec 2002 19:05:09 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 17230 invoked from network); 30 Dec 2002 19:05:08 -0000 Received: from unknown (HELO e35.co.us.ibm.com) (32.97.110.133) by 209.249.29.67 with SMTP; 30 Dec 2002 19:05:08 -0000 Received: from westrelay03.boulder.ibm.com (westrelay03.boulder.ibm.com [9.17.194.24]) by e35.co.us.ibm.com (8.12.2/8.12.2) with ESMTP id gBUJ4KYN012784; Mon, 30 Dec 2002 14:04:20 -0500 Received: from unknown.host (lig32-224-94-67.us.lig-dial.ibm.com [32.224.94.67]) by westrelay03.boulder.ibm.com (8.12.3/NCO/VER6.4) with ESMTP id gBUJ4GdJ051046; Mon, 30 Dec 2002 12:04:17 -0700 Received: (from janis@localhost) by unknown.host (8.9.3/8.9.3) id LAA30878; Mon, 30 Dec 2002 11:06:52 -0800 Date: Mon, 30 Dec 2002 12:58:00 -0000 From: Janis Johnson To: "Kaveh R. Ghazi" Cc: janis187@us.ibm.com, gcc@gcc.gnu.org Subject: Re: Analysis of g++.dg/bprob/g++-bprob-1.C multilib failures Message-ID: <20021230110652.A30867@us.ibm.com> References: <200212271716.MAA29305@caip.rutgers.edu> <200212281613.LAA12655@caip.rutgers.edu> <20021228182629.A22548@us.ibm.com> <200212292046.PAA04172@caip.rutgers.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200212292046.PAA04172@caip.rutgers.edu>; from ghazi@caip.rutgers.edu on Sun, Dec 29, 2002 at 03:46:30PM -0500 X-SW-Source: 2002-12/txt/msg01594.txt.bz2 On Sun, Dec 29, 2002 at 03:46:30PM -0500, Kaveh R. Ghazi wrote: > > From: Janis Johnson > > > > On Sat, Dec 28, 2002 at 11:13:14AM -0500, Kaveh R. Ghazi wrote: > > > > > > I'm kind of stuck, since this is a maze of dejagnu stuff. If someone > > > has ideas I would appreciate some help on this one. > > > > I wrote the framework for those tests, so perhaps I could figure out > > what's going on. I've never used multilibs; is that something I could > > do with a cross compiler (and simulator) on my i686-pc-linux-gnu laptop > > while I'm at home during the next few days? It's cranking away looking > > for patches that introduced regressions, but it could be put to work > > doing something else for a while, and I can interrupt my weaving and > > papermaking and baking and lazing about to try to remember what those > > tests are doing. > > Janis > > Thanks Janis, that'll be a big help. While you may be able to > recreate the error with a multilib simulator, I suspect you may be > able to use *any* multipass testsuite run. For example, one regular > (plain vanilla) pass and one -fPIC pass. That would work on a native > x86-linux-gnu box and should be much simpler since the cross stuff > won't come into play. If you have the trunk already built and handy, > as a first guess try: > > make RUNTESTFLAGS="--target_board 'unix{-fPIC,-fpic,}'" check-gcc-c++ > > see if that triggers it for you. Yes, that did it. This patch fixes the C++ bprob tests when running the C++ test suite with multiple sets of options. Those tests were using a global variable that was also used in other tests, but this change affects only the outcome of the bprob tests. Tested with the gcc-20021202 snapshot with and without the patch on i686-pc-linux-gnu with make RUNTESTFLAGS="--target_board 'unix{-fPIC,-fpic,}'" check-c++ I won't have CVS access for the next few days, so if this looks OK please check it in. 2002-12-30 Janis Johnson * lib/profopt.exp: Change the name of a global variable to avoid possible clashes with other test suites. --- testsuite/lib/profopt.exp.orig Sun Dec 29 16:45:07 2002 +++ testsuite/lib/profopt.exp Sun Dec 29 16:45:21 2002 @@ -66,7 +66,7 @@ { -Os } ] } -set option_list $PROFOPT_OPTIONS +set prof_option_list $PROFOPT_OPTIONS # # profopt-cleanup -- remove profiling or performance results files. @@ -126,7 +126,7 @@ # proc profopt-execute { src } { global srcdir tmpdir - global option_list + global prof_option_list global tool profile_option feedback_option prof_ext perf_ext perf_delta global verbose @@ -142,7 +142,7 @@ set executable $tmpdir/[file tail [file rootname $src].x] set count 0 - foreach option $option_list { + foreach option $prof_option_list { set execname1 "${executable}${count}1" set execname2 "${executable}${count}2" set execname3 "${executable}${count}3"