From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: gcc@gcc.gnu.org
Cc: neil@daikokuya.co.uk, zack@codesourcery.com
Subject: Picking one solution to the "struct cpp_reader" protos.h problem
Date: Thu, 23 Jan 2003 16:25:00 -0000 [thread overview]
Message-ID: <200301230249.VAA10183@caip.rutgers.edu> (raw)
Some protos.h files have prototypes which take a "struct cpp_reader *"
as a parameter. This yields the "`struct cpp_reader' declared inside
parameter list" warning because cpp_reader isn't yet declared.
We now have three competing proposals/implementations to fix it.
1. Declare "struct cpp_reader" inside the protos.h file (arm-protos.h)
2. Wrap the prototypes inside some macro defined in cpplib.h to
ensure we already have the cpp_reader declaration. If this one,
then which macro? See rs6000-protos.h which uses GCC_CPPLIB_H.
3. Put struct cpp_reader in coretypes.h. See:
http://gcc.gnu.org/ml/gcc-patches/2003-01/msg01271.html
(This hasn't been done yet.)
I think we should be consistent. Which of these solutions should we
use across the board? Opinions?
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu
next reply other threads:[~2003-01-23 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-23 16:25 Kaveh R. Ghazi [this message]
2003-01-23 17:07 ` Neil Booth
2003-01-23 19:56 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301230249.VAA10183@caip.rutgers.edu \
--to=ghazi@caip.rutgers.edu \
--cc=gcc@gcc.gnu.org \
--cc=neil@daikokuya.co.uk \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).