public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* Weird comment in flow.c
@ 2003-02-02 17:04 Zdenek Dvorak
  2003-02-02 18:23 ` Jan Hubicka
  0 siblings, 1 reply; 3+ messages in thread
From: Zdenek Dvorak @ 2003-02-02 17:04 UTC (permalink / raw)
  To: gcc

Hello,

this comment is found in flow.c:

The post-reload life analysis have (on a global basis) the same
registers live as was computed by reload itself.  elimination
Otherwise offsets and such may be incorrect.

Does someone know what should it say correctly?

Zdenek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Weird comment in flow.c
  2003-02-02 17:04 Weird comment in flow.c Zdenek Dvorak
@ 2003-02-02 18:23 ` Jan Hubicka
  2003-02-04  2:08   ` Richard Henderson
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Hubicka @ 2003-02-02 18:23 UTC (permalink / raw)
  To: Zdenek Dvorak; +Cc: gcc

> Hello,
> 
> this comment is found in flow.c:
> 
> The post-reload life analysis have (on a global basis) the same
> registers live as was computed by reload itself.  elimination
> Otherwise offsets and such may be incorrect.
> 
> Does someone know what should it say correctly?

I think the comment is correct after swapping elimination and Otherwise.
Reload compute frame size that includes register save area that is emit
post reload based on flow2 analysis.  So in case we get different amount
of registers to save, the offsets may not match.
At least I believe to this :)

Honza
> 
> Zdenek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Weird comment in flow.c
  2003-02-02 18:23 ` Jan Hubicka
@ 2003-02-04  2:08   ` Richard Henderson
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2003-02-04  2:08 UTC (permalink / raw)
  To: Jan Hubicka; +Cc: Zdenek Dvorak, gcc

On Sun, Feb 02, 2003 at 07:22:55PM +0100, Jan Hubicka wrote:
> I think the comment is correct after swapping elimination and Otherwise.

That is correct.  I suspect that someone hit M-t while editing
here and swapped the words.  That seems clear from the capitalization.


r~

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-02-04  2:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-02 17:04 Weird comment in flow.c Zdenek Dvorak
2003-02-02 18:23 ` Jan Hubicka
2003-02-04  2:08   ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).