Re: General search for symbols...

Re: General search for symbols...

[Ilia Dyatchkov]

>I am trying to port GCC to another machine.
>Given that I have a file <new gcc
>path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
>functions in that file find out if a certain symbol has been defined by
>a "#define" statement in the C source that is being compiled?
>
>E.g., the source file consists of one line:
>#define DEFINED_CONSTANT_2
>
>Note: my call to print_node CRASHES the compiler.
>
>I have tried various versions of:
>
>  if((decl = getdecls()))
>    print_node(stderr,"tree: ",decl,4);  /* this CRASHES!!! */

Try debug_tree(decl);

>
>  for ( ; decl; decl = TREE_CHAIN (decl))
>  {
>    if (TREE_CODE (decl) == IDENTIFIER_NODE)
>    {
>      if(!strcmp(IDENTIFIER_POINTER(decl),"DEFINED_CONSTANT_1"))
>        fprintf(stderr,"DEFINED_CONSTANT_1" found, code 
>%d\n",TREE_CODE(decl));
>      else if(!strcmp(IDENTIFIER_POINTER(decl),"DEFINED_CONSTANT_2"))
>        fprintf(stderr,"DEFINED_CONSTANT_2 found, code
>%d\n",TREE_CODE(decl));
>    }
>  }

Re: General search for symbols...

[Mike Stump]

On Thursday, April 10, 2003, at 12:20 PM, Zack Weinberg wrote:
> What do you think of this revision?  I'm not entirely happy with the
> wording.

I think it looks ok.  If you really want me to nit-pick, maybe I'd say, 
`No longer ships' might be a tad informal or might cause grief for our 
International users?

Re: General search for symbols...

[Zack Weinberg]

Mike Stump <mrs@apple.com> writes:

> Ok, I am confused then.  What does the varargs.h header in 3.3 do then:
>
> #ifndef _VARARGS_H
> #define _VARARGS_H
>
> #error "GCC no longer implements <varargs.h>."
> #error "Revise your code to use <stdarg.h>."
>
> #endif

This would be what we call "jumping to conclusions based on the
existence of the file."

What do you think of this revision?  I'm not entirely happy with the
wording.

zw

===================================================================
Index: gcc-3.3/changes.html
--- gcc-3.3/changes.html	21 Mar 2003 09:01:04 -0000	1.22
+++ gcc-3.3/changes.html	10 Apr 2003 19:20:25 -0000
@@ -53,7 +53,10 @@
 
     <li>The <code>-traditional</code> C compiler option has been
         removed.  It was deprecated in 3.1 and 3.2.  (Traditional
-        preprocessing remains available.)</li>
+        preprocessing remains available.)  The
+        <code>&lt;varargs.h&gt;</code> header, used for writing
+	variadic functions in traditional C, still exists but will
+	produce an error message if used.</li>
   </ul>
 
 
===================================================================
Index: gcc-3.4/changes.html
--- gcc-3.4/changes.html	10 Apr 2003 05:33:54 -0000	1.19
+++ gcc-3.4/changes.html	10 Apr 2003 19:20:25 -0000
@@ -22,11 +22,8 @@
     <li>GCC no longer accepts the options <code>-fvolatile</code>,
 	<code>-fvolatile-global</code> and <code>-fvolatile-static</code>.
 	It is unlikely that they worked correctly in any 3.x release.</li>
-    <li>GCC no longer supports the use of <code>&lt;varargs.h&gt;</code>
-        and does not provide this header with the distribution.  Use
-        <code>&lt;stdarg.h&gt;</code> instead.  (This header is primarily
-        useful with traditional mode compilation, which feature was removed
-        in GCC 3.3.)
+    <li>GCC no longer ships <code>&lt;varargs.h&gt;</code>.  Use
+        <code>&lt;stdarg.h&gt;</code> instead.</li>
   </ul>
 
 <h2>General Optimizer Improvements</h2>

Re: General search for symbols...

[Mike Stump]

On Wednesday, April 9, 2003, at 10:33 PM, Zack Weinberg wrote:
> Joe Buck <jbuck@synopsys.com> writes:
>
>> Zack writes:
>>> Note that as of 3.3 GCC no longer supports <varargs.h>, although 
>>> there
>>> are still vestiges of the old code for it.
>>
>> We should have a mention of that (together with any other deprecated
>> features not already mentioned) on
>>
>> http://gcc.gnu.org/gcc-3.3/changes.html
>
> Done.  (I misspoke; it was only removed in 3.4, although it doesn't
> make a lot of sense to use <varargs.h> with 3.3 which dropped
> -traditional.)

Ok, I am confused then.  What does the varargs.h header in 3.3 do then:

#ifndef _VARARGS_H
#define _VARARGS_H

#error "GCC no longer implements <varargs.h>."
#error "Revise your code to use <stdarg.h>."

#endif

?

Re: General search for symbols...

[Zack Weinberg]

Joe Buck <jbuck@synopsys.com> writes:

> Zack writes:
>> Note that as of 3.3 GCC no longer supports <varargs.h>, although there
>> are still vestiges of the old code for it.
>
> We should have a mention of that (together with any other deprecated
> features not already mentioned) on
>
> http://gcc.gnu.org/gcc-3.3/changes.html 

Done.  (I misspoke; it was only removed in 3.4, although it doesn't
make a lot of sense to use <varargs.h> with 3.3 which dropped
-traditional.)

zw

===================================================================
Index: gcc-3.4/changes.html
--- gcc-3.4/changes.html	6 Apr 2003 15:18:53 -0000	1.18
+++ gcc-3.4/changes.html	10 Apr 2003 05:33:19 -0000
@@ -22,6 +22,11 @@
     <li>GCC no longer accepts the options <code>-fvolatile</code>,
 	<code>-fvolatile-global</code> and <code>-fvolatile-static</code>.
 	It is unlikely that they worked correctly in any 3.x release.</li>
+    <li>GCC no longer supports the use of <code>&lt;varargs.h&gt;</code>
+        and does not provide this header with the distribution.  Use
+        <code>&lt;stdarg.h&gt;</code> instead.  (This header is primarily
+        useful with traditional mode compilation, which feature was removed
+        in GCC 3.3.)
   </ul>
 
 <h2>General Optimizer Improvements</h2>

Re: General search for symbols...

[Stephen Biggs]

On Thu, 2003-04-03 at 22:11, Hans-Peter Nilsson wrote:
> On 3 Apr 2003, Stephen Biggs wrote:
> 
> > On Wed, 2003-04-02 at 13:34, Hans-Peter Nilsson wrote:
> > > On 2 Apr 2003, Stephen Biggs wrote:
> > > > I am trying to port GCC to another machine.
> > > >
> > > > Given that I have a file <new gcc
> > > > path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
> > > > functions in that file find out if a certain symbol has been defined by
> > > > a "#define" statement in the C source that is being compiled?
> > >
> > > That's an odd need for a new port.  Care to elaborate; example?
> > > (It might turn out to be a misunderstanding or a need covered
> > > by an existing mechanism, that's mainly why I ask.)
> >
> > Thanks for the reply.
> >
> > E.g., I need to do something different in the assembly output based on
> > whether varargs.h or stdarg.h was included in the C source file.
> 
> Maybe that need is covered by the macro current_function_stdarg.
> See function.h.  That particular macro unfortunately seems not
> documented.  See also other ports.  One or another has probably
> solved the same problem your port has.

Ok... I'll check, thanks for the reply.

> 
> > I
> > thought to check to see if either "_VARARGS_H" or "_STDARG_H" was
> > defined.  I am also going to need this for other things.
> 
> I can't guess what you mean by "other things" so I can't help
> you there.

I wish I could tell you, but I am not at liberty, at this time... Thanks
for the advice.

I believe that if I check to see if the function decl for "va_end"
exists, then this tells me whether I am running stdarg or varargs...

> 
> brgds, H-P
> 
> 

Re: General search for symbols...

[Joe Buck]

Zack writes:
> Note that as of 3.3 GCC no longer supports <varargs.h>, although there
> are still vestiges of the old code for it.

We should have a mention of that (together with any other deprecated
features not already mentioned) on

http://gcc.gnu.org/gcc-3.3/changes.html 

Re: General search for symbols...

[Zack Weinberg]

Hans-Peter Nilsson <hp@bitrange.com> writes:

> On 3 Apr 2003, Stephen Biggs wrote:
>
>> On Wed, 2003-04-02 at 13:34, Hans-Peter Nilsson wrote:
>> > On 2 Apr 2003, Stephen Biggs wrote:
>> > > I am trying to port GCC to another machine.
>> > >
>> > > Given that I have a file <new gcc
>> > > path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
>> > > functions in that file find out if a certain symbol has been defined by
>> > > a "#define" statement in the C source that is being compiled?
>> >
>> > That's an odd need for a new port.  Care to elaborate; example?
>> > (It might turn out to be a misunderstanding or a need covered
>> > by an existing mechanism, that's mainly why I ask.)
>>
>> Thanks for the reply.
>>
>> E.g., I need to do something different in the assembly output based on
>> whether varargs.h or stdarg.h was included in the C source file.
>
> Maybe that need is covered by the macro current_function_stdarg.
> See function.h.  That particular macro unfortunately seems not
> documented.  See also other ports.  One or another has probably
> solved the same problem your port has.

Note that as of 3.3 GCC no longer supports <varargs.h>, although there
are still vestiges of the old code for it.

zw

Re: General search for symbols...

[Hans-Peter Nilsson]

On 3 Apr 2003, Stephen Biggs wrote:

> On Wed, 2003-04-02 at 13:34, Hans-Peter Nilsson wrote:
> > On 2 Apr 2003, Stephen Biggs wrote:
> > > I am trying to port GCC to another machine.
> > >
> > > Given that I have a file <new gcc
> > > path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
> > > functions in that file find out if a certain symbol has been defined by
> > > a "#define" statement in the C source that is being compiled?
> >
> > That's an odd need for a new port.  Care to elaborate; example?
> > (It might turn out to be a misunderstanding or a need covered
> > by an existing mechanism, that's mainly why I ask.)
>
> Thanks for the reply.
>
> E.g., I need to do something different in the assembly output based on
> whether varargs.h or stdarg.h was included in the C source file.

Maybe that need is covered by the macro current_function_stdarg.
See function.h.  That particular macro unfortunately seems not
documented.  See also other ports.  One or another has probably
solved the same problem your port has.

> I
> thought to check to see if either "_VARARGS_H" or "_STDARG_H" was
> defined.  I am also going to need this for other things.

I can't guess what you mean by "other things" so I can't help
you there.

brgds, H-P

Re: General search for symbols...

[Stephen Biggs]

On Wed, 2003-04-02 at 13:34, Hans-Peter Nilsson wrote:
> On 2 Apr 2003, Stephen Biggs wrote:
> > I am trying to port GCC to another machine.
> >
> > Given that I have a file <new gcc
> > path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
> > functions in that file find out if a certain symbol has been defined by
> > a "#define" statement in the C source that is being compiled?
> 
> That's an odd need for a new port.  Care to elaborate; example?
> (It might turn out to be a misunderstanding or a need covered
> by an existing mechanism, that's mainly why I ask.)

Thanks for the reply.

E.g., I need to do something different in the assembly output based on
whether varargs.h or stdarg.h was included in the C source file. I
thought to check to see if either "_VARARGS_H" or "_STDARG_H" was
defined.  I am also going to need this for other things.

> 
> brgds, H-P
> 
> 

Re: General search for symbols...

[Hans-Peter Nilsson]

On 2 Apr 2003, Stephen Biggs wrote:
> I am trying to port GCC to another machine.
>
> Given that I have a file <new gcc
> path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
> functions in that file find out if a certain symbol has been defined by
> a "#define" statement in the C source that is being compiled?

That's an odd need for a new port.  Care to elaborate; example?
(It might turn out to be a misunderstanding or a need covered
by an existing mechanism, that's mainly why I ask.)

brgds, H-P

General search for symbols...

[Stephen Biggs]

I am trying to port GCC to another machine.

Given that I have a file <new gcc
path>/gcc/config/<machine>/<machine>.c, how would I, within any of the
functions in that file find out if a certain symbol has been defined by
a "#define" statement in the C source that is being compiled?

E.g., the source file consists of one line:
#define DEFINED_CONSTANT_2

Note: my call to print_node CRASHES the compiler.

I have tried various versions of:

  if((decl = getdecls()))
    print_node(stderr,"tree: ",decl,4);  /* this CRASHES!!! */

  for ( ; decl; decl = TREE_CHAIN (decl))
  {
    if (TREE_CODE (decl) == IDENTIFIER_NODE)
    {
      if(!strcmp(IDENTIFIER_POINTER(decl),"DEFINED_CONSTANT_1"))
        fprintf(stderr,"DEFINED_CONSTANT_1" found, code 
%d\n",TREE_CODE(decl));
      else if(!strcmp(IDENTIFIER_POINTER(decl),"DEFINED_CONSTANT_2"))
        fprintf(stderr,"DEFINED_CONSTANT_2 found, code
%d\n",TREE_CODE(decl));
    }
  }