From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4027 invoked by alias); 7 May 2003 01:27:38 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 4018 invoked from network); 7 May 2003 01:27:37 -0000 Received: from unknown (HELO mx2.redhat.com) (12.150.115.133) by sources.redhat.com with SMTP; 7 May 2003 01:27:37 -0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.11.6/8.11.6) with ESMTP id h471H7Z01786; Tue, 6 May 2003 21:17:07 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h471RaT21362; Tue, 6 May 2003 21:27:36 -0400 Received: from dot.sfbay.redhat.com (dot.sfbay.redhat.com [172.16.24.7]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h471RaM08328; Tue, 6 May 2003 18:27:36 -0700 Received: (from rth@localhost) by dot.sfbay.redhat.com (8.11.6/8.11.6) id h471P8M07688; Tue, 6 May 2003 18:25:08 -0700 X-Authentication-Warning: dot.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Wed, 07 May 2003 01:27:00 -0000 From: Richard Henderson To: Ulrich Weigand Cc: mark@codesourcery.com, gcc@gcc.gnu.org Subject: Re: GCC 3.3 Prelease broken on s390 Message-ID: <20030507012508.GD7654@redhat.com> Mail-Followup-To: Richard Henderson , Ulrich Weigand , mark@codesourcery.com, gcc@gcc.gnu.org References: <200305070113.DAA15839@faui11.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305070113.DAA15839@faui11.informatik.uni-erlangen.de> User-Agent: Mutt/1.4i X-SW-Source: 2003-05/txt/msg00572.txt.bz2 On Wed, May 07, 2003 at 03:13:39AM +0200, Ulrich Weigand wrote: > ... which is completely ignored on s390 anyway (as SP is > restored from its stack slot, where the correct new > value was already stored by uw_install_context_1). Ah, now I get it. This was the piece I couldn't understand. And if *this* is the case, it means that it doesn't matter where you place the CFA relative to the stack frame, just so long as the stack pointer itself is computed properly. > What do you think? > > * unwind-dw2.c (uw_update_context_1): Only set cfa as sp if > previous frame didn't save sp. Clear sp for next frame. > (uw_install_context_1): Honor saved sp from frame. If this works, great. r~