From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21855 invoked by alias); 7 May 2003 17:09:25 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 21845 invoked from network); 7 May 2003 17:09:24 -0000 Received: from unknown (HELO piper.synopsys.com) (204.176.21.196) by sources.redhat.com with SMTP; 7 May 2003 17:09:24 -0000 Received: (from jbuck@localhost) by piper.synopsys.com (8.11.6/8.11.6) id h47H7Up07777; Wed, 7 May 2003 10:07:30 -0700 Date: Wed, 07 May 2003 17:09:00 -0000 From: Joe Buck To: Ulrich Weigand Cc: Mark Mitchell , rth@redhat.com, gcc@gcc.gnu.org Subject: Re: GCC 3.3 Prelease broken on s390 Message-ID: <20030507100730.A7766@synopsys.com> References: <1052322820.23765.5.camel@minax.codesourcery.com> <200305071702.TAA11631@faui11.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200305071702.TAA11631@faui11.informatik.uni-erlangen.de>; from weigand@immd1.informatik.uni-erlangen.de on Wed, May 07, 2003 at 07:02:49PM +0200 X-SW-Source: 2003-05/txt/msg00648.txt.bz2 On Wed, May 07, 2003 at 07:02:49PM +0200, Ulrich Weigand wrote: > It should be obvious that it does not affect other platforms; > the hunk in uw_update_context_1 is under #ifdef, and the hunk > in uw_init_context_1 does not affect non-s390 platforms because > for them uw_update_context_1 will immediately undo that change > (never mind that even if it didn't, the change would in fact > be correct for other platforms as well). Given the very short time remaining for testing, if you're ifdef'ing one hunk, you might as well ifdef them both. The patch would then have zero risk for other platforms.