PATCH: Fix "proc find" in dejagnu

PATCH: Fix "proc find" in dejagnu

[H. J. Lu]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

"proc find" is using "getdirs -all" incorrectly. When "getdirs -all" is
used, there is no need to try to get all directories yourselves. The
current "proc find" will list any file not in the root directory
twice. This patch should fix it.

BTW, is anyone working on dejagnu? I have found and fixed 3 bugs
in less than 2 weeks since I was forced to use dejagnu 1.4.3. I didn't
get any reponses nor any indications those bugs would be fixed any
time soon.



H.J.

[-- Attachment #2: dejagnu-find.patch --]
[-- Type: text/plain, Size: 807 bytes --]

2003-05-19  H.J. Lu <hongjiu.lu@intel.com>

	* lib/utils.exp (find): Correctly use [getdirs -all $rootdir].

--- dejagnu/lib/utils.exp.recursive	2002-08-29 20:54:53.000000000 -0700
+++ dejagnu/lib/utils.exp	2003-05-18 23:42:17.000000000 -0700
@@ -97,25 +97,7 @@ proc getdirs { args } {
 #
 proc find { rootdir pattern } {
     # first find all the directories
-    set dirs "$rootdir "
-    while 1 {
-	set tmp $rootdir
-	set rootdir ""
-	if [string match "" $tmp] {
-	    break
-	}
-	foreach i $tmp {
-	    set j [getdirs -all $i]
-	    if ![string match "" $j] {
-		append dirs "$j "
-		set rootdir $j
-		unset j
-	    } else {
-		set rootdir ""
-	    }
-	}
-	set tmp ""
-    }
+    set dirs "$rootdir [getdirs -all $rootdir]"
     
     # find all the files that match the pattern
     foreach i $dirs {

Re: PATCH: Fix "proc find" in dejagnu

[Rob Savoye]

On Sun, May 18, 2003 at 11:57:10PM -0700, H. J. Lu wrote:

> BTW, is anyone working on dejagnu? I have found and fixed 3 bugs
> in less than 2 weeks since I was forced to use dejagnu 1.4.3. I didn't
> get any reponses nor any indications those bugs would be fixed any
 
  Yes, somebody is still working on it, classically as a "side gig" to
my income generating work... I've encorporated all your patches into my
local source tree, and as they were mostly obvious, I didn't feel a need
for discussion. I still have to test them. Personally, if you don't like
DejaGnu don't use it... or implement something better. Dissing DejaGnu
isn't really a good way to get me to respond. DejaGnu is over 12 years
old, and could use some work to make it more up to date. Maybe someday
I'll have that much (free) time, but till then, about all I can do is
keep patching it so it's at least useful to the GNU development tools,
since not too many other projects bother to do any real testing. As
almost nobody else has ever stepped forward to help with maintaining
DejaGnu, it's pretty much a solo effort. I unfortunately find my new
GNU project (http://www.senecass.com/abelmon/) way more stimulating than
hacking on regression testing frameworks full-time for another 12 years. 

	- rob -

Re: PATCH: Fix "proc find" in dejagnu

[Gerald Pfeifer]

On Mon, 19 May 2003, Rob Savoye wrote:
> I'll have that much (free) time, but till then, about all I can do is
> keep patching it so it's at least useful to the GNU development tools,
> since not too many other projects bother to do any real testing.

Note that I wrote in my response to HJ that I found you responsive. ;-)

In any case, if those fixes HJ submitted (and possibly other that you
mad in the meantime as well) are critical, perhaps you could roll a new
release of DejaGnu?

And if those fixes are necessary (at least on some platforms) for the
GCC testsuite to run correctly, we probably should then specify this
new version as a requirement in our installation/testing documentation.

Gerald
-- 
Gerald "Jerry"   pfeifer@dbai.tuwien.ac.at   http://www.pfeifer.com/gerald/

Re: PATCH: Fix "proc find" in dejagnu

[Rob Savoye]

On Sat, May 24, 2003 at 03:55:17PM +0200, Gerald Pfeifer wrote:


> In any case, if those fixes HJ submitted (and possibly other that you
> mad in the meantime as well) are critical, perhaps you could roll a new
> release of DejaGnu?

  I guess I can give it a shot, considering GCC 3.3 just came out. It might
also be a good idea for somebody on the GCC team to check fixes into DejaGnu's
CVS tree on subversions in the future, eliminating my "time lag" to merge and
test. Anyone with an account on subversions should be able to write to
DejaGnu's repository.

  The only thing worth waiting for before another release is Chris's changes
to the XML output format to handle GCC multilib testing better. I still need
a patch... :-)

  	- rob -

Re: PATCH: Fix "proc find" in dejagnu

[Rob Savoye]

On Sat, May 24, 2003 at 09:12:00AM -0700, cgd@broadcom.com wrote:

> first i wanted to have some real understanding of XML (got and read the
> ora xml in a nutshell).  then, got over-ambitious, and when i was about
> 1/4 done with what i was doing realized it wasn't doable.  then, ran low
> on time.  8-)
 
  We could use your older patch, but since we talked about doing it right,
rather than preserving the compatability with the current format, I'd love
to not release a version that's gonna change real soon now... I can start
testing the other changes in the meanwhile.
  
  A more ambitious project for the future would be to rewrite the target
config and base board files to optionally use XML, rather than Tcl variables.
That and a direct MySQL or ODBC connection, so you could skip the XML step. 

  	- rob -

Re: PATCH: Fix "proc find" in dejagnu

[cgd]

>   The only thing worth waiting for before another release is Chris's changes
> to the XML output format to handle GCC multilib testing better. I still need
> a patch... :-)

yeah, sorry.

first i wanted to have some real understanding of XML (got and read the
ora xml in a nutshell).  then, got over-ambitious, and when i was about
1/4 done with what i was doing realized it wasn't doable.  then, ran low
on time.  8-)

I'll try to get something out this week.



chris