From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10993 invoked by alias); 20 May 2003 09:15:58 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 803 invoked from network); 20 May 2003 08:57:17 -0000 Received: from unknown (HELO nikam.ms.mff.cuni.cz) (195.113.18.106) by sources.redhat.com with SMTP; 20 May 2003 08:57:17 -0000 Received: from camelot.ms.mff.cuni.cz (kampanus.ms.mff.cuni.cz [195.113.18.107]) by nikam.ms.mff.cuni.cz (Postfix) with SMTP id 47CA34E2BD; Tue, 20 May 2003 10:57:17 +0200 (CEST) Received: by camelot.ms.mff.cuni.cz (sSMTP sendmail emulation); Tue, 20 May 2003 10:57:47 +0200 Date: Tue, 20 May 2003 09:24:00 -0000 From: Jan Hubicka To: Jie Zhang Cc: Jan Hubicka , Nathan Sidwell , gcc@gcc.gnu.org, Zdenek Dvorak Subject: Re: [PATCH] Re: Option -fprofile-arcs fails for target avr and fr30 Message-ID: <20030520085747.GC1375@kam.mff.cuni.cz> References: <3EC4B4D8.1040504@magima.com.cn> <3EC84136.6040705@magima.com.cn> <3EC89EDC.4000706@codesourcery.com> <20030519135752.GD15316@kam.mff.cuni.cz> <3EC98E5A.7050008@magima.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EC98E5A.7050008@magima.com.cn> User-Agent: Mutt/1.3.28i X-SW-Source: 2003-05/txt/msg01844.txt.bz2 > Jan Hubicka wrote: > > >There is code to set the JUMP_LABEL properly in the code to emit insn on > >the edges: > > insert_insn_on_edge (edge_profile, e); > > rebuild_jump_labels (e->insns); > >rebuild_jump_labels is supposed to update JUMP_LABEL accordingly. > >In case the profiling code somewhere does not update labels correctly it > >is the bug on place where code is emit. I will try to figure out what > >happens tomorrow. At the time the basic blocks are split, all > >JUMP_LABELs are supposed to be up-to-date. > > > >Honza > > > > > > > > > Sorry, I didn't see that rebuild_jump_labels was added into HEAD of cvs > on Mar 30, 2003, I'm only tracking 3.3 branch now, which had been > branched before it was added. Now how do we fix this bug on 3.3 branch? Bacporting that patch I guess. It should be safe. Honza > > - Jie >