From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
To: dj@redhat.com
Cc: crossgcc@sources.redhat.com, gcc-patches@gcc.gnu.org,
gcc@gcc.gnu.org, peter@baradas.org
Subject: Re: failure building gcc-3.3 (broken libiberty/vsprintf.c or build?)
Date: Tue, 20 May 2003 21:06:00 -0000 [thread overview]
Message-ID: <200305202059.QAA18111@caip.rutgers.edu> (raw)
In-Reply-To: <200305201609.h4KG9jR20778@greed.delorie.com>
> > gcc-3.3/lbiberty/vsprintf.c, indeed includes <varargs.h> (which gcc
> > supplies), so if gcc-3.3 has killed support for varargs,h, why is
> > libiberty/vsprintf.c trying to include it.
>
> That code in libiberty is ancient. If it's broken now, that means
> that whoever dropped support for varargs.h didn't test it well enough.
FWIW, it appears to be fixed on mainline. We can backport vsprintf.c
to 3.3.1 if you think it's worth fixing. Here's the diff:
--- cvs-egcc-3.3/gcc/libiberty/vsprintf.c 2002-01-22 15:03:29.000000000 -0500
+++ cvs-egcc/gcc/libiberty/vsprintf.c 2003-04-15 16:34:40.516093000 -0400
@@ -26,9 +26,13 @@ the resulting executable to be covered b
This exception does not however invalidate any other reasons why
the executable file might be covered by the GNU General Public License. */
+#include <ansidecl.h>
+#ifdef ANSI_PROTOTYPES
+#include <stdarg.h>
+#else
#include <varargs.h>
+#endif
#include <stdio.h>
-#include <ansidecl.h>
#undef vsprintf
#if defined _IOSTRG && defined _IOWRT
next prev parent reply other threads:[~2003-05-20 20:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-20 6:12 Peter Barada
2003-05-20 6:53 ` Erik Christiansen
2003-05-20 10:53 ` Kai Ruottu
2003-05-20 10:44 ` Kai Ruottu
2003-05-21 4:55 ` Peter Barada
2003-05-21 7:13 ` Peter Barada
2003-05-21 15:05 ` Randy Rude
2003-05-21 15:38 ` Peter Barada
2003-05-21 16:56 ` Randy Rude
2003-05-21 17:28 ` Joe Buck
2003-05-21 17:39 ` DJ Delorie
2003-05-22 14:59 ` Randy Rude
2003-05-22 17:36 ` DJ Delorie
2003-05-23 19:40 ` Randy Rude
2003-05-22 3:14 ` Peter Barada
2003-05-22 12:17 ` Kai Ruottu
2003-05-22 13:33 ` Peter Barada
2003-05-23 3:25 ` Peter Barada
2003-05-20 16:19 ` DJ Delorie
2003-05-20 21:06 ` Kaveh R. Ghazi [this message]
2003-05-20 21:44 ` DJ Delorie
2003-05-23 15:30 ` Kaveh R. Ghazi
2003-05-23 17:49 ` Joe Buck
2003-05-23 18:17 ` Peter Barada
2003-05-23 18:17 ` Joe Buck
2003-05-23 18:39 ` Peter Barada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305202059.QAA18111@caip.rutgers.edu \
--to=ghazi@caip.rutgers.edu \
--cc=crossgcc@sources.redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=peter@baradas.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).