From: Carlo Wood <carlo@alinoe.com>
To: Richard Henderson <rth@redhat.com>,
gcc@gcc.gnu.org, wilson@specifixinc.com, jason@redhat.com
Subject: Re: RFA: Adding a location_t (or pointer) to tree_exp for 3.4 only.
Date: Mon, 06 Oct 2003 22:30:00 -0000 [thread overview]
Message-ID: <20031006223034.GA31753@alinoe.com> (raw)
In-Reply-To: <20031006215536.GB9757@redhat.com>
On Mon, Oct 06, 2003 at 02:55:36PM -0700, Richard Henderson wrote:
> On Mon, Oct 06, 2003 at 11:53:15PM +0200, Carlo Wood wrote:
> > get_callee_fndecl is one.
> >
> > It says:
> >
> > if (TREE_CODE (call) != CALL_EXPR)
> > abort ();
> >
> > ... it did abort.
>
> And why exactly would you be calling get_callee_fndecl on a WFL
> in the first place?
Normally, get_callee_fndecl is called with a CALL_EXPR
as might be clear from the abort test :).
Now I don't understand your remark because when I add a location
to every CALL_EXPR by means of wrapping every CALL_EXPR in a WFL,
then get_callee_fndecl is thus called with a WFL that wraps the
CALL_EXPR. That was the whole point no? To *replace* *every*
CALL_EXPR with a EXPR_WITH_FILE_LOCATION, so I did :/
Now tell me I need to make an exception for get_callee_fndecl
because that would be the first of many exceptions that would
make this totally unmaintainable - or I am missing something.
/usr/src/GNU/gcc/gcc-mainline/gcc>grep get_callee_fndecl *.c
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: fndecl = get_callee_fndecl (t);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
builtins.c: tree fndecl = get_callee_fndecl (exp);
calls.c: fndecl = get_callee_fndecl (exp);
cgraphunit.c: tree decl = get_callee_fndecl (*tp);
dojump.c: tree fndecl = get_callee_fndecl (exp);
fold-const.c: fndecl = get_callee_fndecl (arg0);
fold-const.c: fndecl = get_callee_fndecl (arg0);
fold-const.c: tree fndecl = get_callee_fndecl (arg0);
fold-const.c: tree fndecl = get_callee_fndecl (t);
function.c: fntype = get_callee_fndecl (fntype);
tree.c: tree fn = get_callee_fndecl (t);
tree.c:get_callee_fndecl (tree call)
tree-inline.c: t = get_callee_fndecl (node);
tree-inline.c: fn = get_callee_fndecl (t);
--
Carlo Wood <carlo@alinoe.com>
next prev parent reply other threads:[~2003-10-06 22:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 2:31 RFC: debug line info & inlining; patch proposal and request for comments Carlo Wood
2003-09-23 5:33 ` Jim Wilson
2003-09-27 16:38 ` RFA: Adding a location_t (or pointer) to tree_exp for 3.4 only Carlo Wood
2003-10-06 12:58 ` Hans-Peter Nilsson
2003-10-06 17:41 ` Richard Henderson
2003-10-06 17:51 ` Daniel Jacobowitz
2003-10-06 18:03 ` Daniel Berlin
2003-10-06 19:20 ` Carlo Wood
2003-10-06 19:08 ` Carlo Wood
2003-10-06 20:11 ` Richard Henderson
2003-10-06 20:14 ` Daniel Jacobowitz
2003-10-06 20:20 ` Richard Henderson
2003-10-06 20:24 ` Daniel Jacobowitz
2003-10-06 21:54 ` Richard Henderson
2003-10-06 21:53 ` Carlo Wood
2003-10-06 21:55 ` Richard Henderson
2003-10-06 22:30 ` Carlo Wood [this message]
2003-10-06 23:17 ` Richard Henderson
2003-10-06 23:49 ` Carlo Wood
2003-10-07 0:07 ` Richard Henderson
2003-10-07 0:43 ` Carlo Wood
2003-10-07 0:46 ` Richard Henderson
2003-10-07 2:40 ` Carlo Wood
2003-10-07 18:32 ` Carlo Wood
2003-10-07 19:08 ` Carlo Wood
2003-10-07 19:46 ` Richard Henderson
2003-10-07 21:12 ` Carlo Wood
2003-10-07 23:43 ` Carlo Wood
2003-10-07 19:41 ` Carlo Wood
2003-10-12 4:32 ` law
2003-10-12 12:02 ` Daniel Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031006223034.GA31753@alinoe.com \
--to=carlo@alinoe.com \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=rth@redhat.com \
--cc=wilson@specifixinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).