From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13929 invoked by alias); 6 Oct 2003 22:30:37 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 13922 invoked from network); 6 Oct 2003 22:30:36 -0000 Received: from unknown (HELO mail.alinoe.com) (62.195.88.134) by sources.redhat.com with SMTP; 6 Oct 2003 22:30:36 -0000 Received: (qmail 32378 invoked by uid 500); 6 Oct 2003 22:30:34 -0000 Date: Mon, 06 Oct 2003 22:30:00 -0000 From: Carlo Wood To: Richard Henderson , gcc@gcc.gnu.org, wilson@specifixinc.com, jason@redhat.com Subject: Re: RFA: Adding a location_t (or pointer) to tree_exp for 3.4 only. Message-ID: <20031006223034.GA31753@alinoe.com> Mail-Followup-To: Richard Henderson , gcc@gcc.gnu.org, wilson@specifixinc.com, jason@redhat.com References: <20030922001710.GA24248@alinoe.com> <20030927124920.GA16447@alinoe.com> <20031006174054.GC17794@redhat.com> <20031006190817.GA9460@alinoe.com> <20031006201102.GA5019@redhat.com> <20031006201423.GA10085@nevyn.them.org> <20031006202057.GB5019@redhat.com> <20031006215315.GA29799@alinoe.com> <20031006215536.GB9757@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031006215536.GB9757@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00182.txt.bz2 On Mon, Oct 06, 2003 at 02:55:36PM -0700, Richard Henderson wrote: > On Mon, Oct 06, 2003 at 11:53:15PM +0200, Carlo Wood wrote: > > get_callee_fndecl is one. > > > > It says: > > > > if (TREE_CODE (call) != CALL_EXPR) > > abort (); > > > > ... it did abort. > > And why exactly would you be calling get_callee_fndecl on a WFL > in the first place? Normally, get_callee_fndecl is called with a CALL_EXPR as might be clear from the abort test :). Now I don't understand your remark because when I add a location to every CALL_EXPR by means of wrapping every CALL_EXPR in a WFL, then get_callee_fndecl is thus called with a WFL that wraps the CALL_EXPR. That was the whole point no? To *replace* *every* CALL_EXPR with a EXPR_WITH_FILE_LOCATION, so I did :/ Now tell me I need to make an exception for get_callee_fndecl because that would be the first of many exceptions that would make this totally unmaintainable - or I am missing something. /usr/src/GNU/gcc/gcc-mainline/gcc>grep get_callee_fndecl *.c builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: fndecl = get_callee_fndecl (t); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); builtins.c: tree fndecl = get_callee_fndecl (exp); calls.c: fndecl = get_callee_fndecl (exp); cgraphunit.c: tree decl = get_callee_fndecl (*tp); dojump.c: tree fndecl = get_callee_fndecl (exp); fold-const.c: fndecl = get_callee_fndecl (arg0); fold-const.c: fndecl = get_callee_fndecl (arg0); fold-const.c: tree fndecl = get_callee_fndecl (arg0); fold-const.c: tree fndecl = get_callee_fndecl (t); function.c: fntype = get_callee_fndecl (fntype); tree.c: tree fn = get_callee_fndecl (t); tree.c:get_callee_fndecl (tree call) tree-inline.c: t = get_callee_fndecl (node); tree-inline.c: fn = get_callee_fndecl (t); -- Carlo Wood