From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1869 invoked by alias); 7 Oct 2003 23:43:24 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 1861 invoked from network); 7 Oct 2003 23:43:23 -0000 Received: from unknown (HELO mail.alinoe.com) (62.195.88.134) by sources.redhat.com with SMTP; 7 Oct 2003 23:43:23 -0000 Received: (qmail 16711 invoked by uid 500); 7 Oct 2003 23:43:21 -0000 Date: Tue, 07 Oct 2003 23:43:00 -0000 From: Carlo Wood To: Richard Henderson , gcc@gcc.gnu.org, wilson@specifixinc.com, jason@redhat.com Subject: Re: RFA: Adding a location_t (or pointer) to tree_exp for 3.4 only. Message-ID: <20031007234321.GA16674@alinoe.com> Mail-Followup-To: Richard Henderson , gcc@gcc.gnu.org, wilson@specifixinc.com, jason@redhat.com References: <20031006215536.GB9757@redhat.com> <20031006223034.GA31753@alinoe.com> <20031006231706.GB4839@redhat.com> <20031006234940.GA3134@alinoe.com> <20031007000703.GD4839@redhat.com> <20031007004305.GA8485@alinoe.com> <20031007004647.GA5397@redhat.com> <20031007183231.GA5743@alinoe.com> <20031007194604.GA18217@redhat.com> <20031007211218.GA11213@alinoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031007211218.GA11213@alinoe.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00245.txt.bz2 I finished the patch that adds the location_t after the expressions' structure (like in OO inheritance). This patch is simple, robust, maintainable and increases the memory usage only with 0.2% instead of the 7% when adding the location_t to tree_exp as a fixed member. The patch certainly is a lot smaller and simpler than a WFL based patch would be - and garanteed bug free, something that I'd not be able to garantee with a patch that uses WFL :/. Also, it uses less memory than when implementing this with WFL (a WFL adds a whole tree struct, which is considerably larger than a location_t). As soon as I did the mandatory bootstrap and gdb testsuite tests, I will post the patch to gcc-patches@ with a CC to you for review. Thanks, -- Carlo Wood