public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: Someone broke bootstrap
@ 2003-10-08  2:47 John David Anglin
  2003-10-08 10:15 ` David Ayers
  0 siblings, 1 reply; 6+ messages in thread
From: John David Anglin @ 2003-10-08  2:47 UTC (permalink / raw)
  To: gcc; +Cc: carlo

How about

if flex  -o g-$$ ../../gcc/gcc/gengtype-lex.l; then \
  mv -f g-$$ ../../gcc/gcc/gengtype-lex.c ; \
else \
  rm -f g-$$ ; \
  false ; \
fi
flex: can't open g-16194

on i686-pc-linux-gnu.

There are also a bunch of testsuite regressions on hppa64-hp-hpux11.11.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Someone broke bootstrap
  2003-10-08  2:47 Someone broke bootstrap John David Anglin
@ 2003-10-08 10:15 ` David Ayers
  2003-10-08 11:57   ` Carlo Wood
  0 siblings, 1 reply; 6+ messages in thread
From: David Ayers @ 2003-10-08 10:15 UTC (permalink / raw)
  To: John David Anglin; +Cc: gcc, carlo, kcook34

John David Anglin wrote:

>How about
>
>if flex  -o g-$$ ../../gcc/gcc/gengtype-lex.l; then \
>  mv -f g-$$ ../../gcc/gcc/gengtype-lex.c ; \
>else \
>  rm -f g-$$ ; \
>  false ; \
>fi
>flex: can't open g-16194
>
>on i686-pc-linux-gnu.
>
>There are also a bunch of testsuite regressions on hppa64-hp-hpux11.11.
>
>Dave
>  
>
This seems to be caused by:

http://gcc.gnu.org/ml/gcc-patches/2003-10/msg00529.html

Is flex 2.5.4 unsupported?

Cheers,
David Ayers


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Someone broke bootstrap
  2003-10-08 10:15 ` David Ayers
@ 2003-10-08 11:57   ` Carlo Wood
  2003-10-08 12:29     ` [PATCH] " Carlo Wood
  0 siblings, 1 reply; 6+ messages in thread
From: Carlo Wood @ 2003-10-08 11:57 UTC (permalink / raw)
  To: David Ayers; +Cc: John David Anglin, gcc, kcook34

On Wed, Oct 08, 2003 at 12:10:14PM +0200, David Ayers wrote:
> John David Anglin wrote:
> >How about
> >
> >if flex  -o g-$$ ../../gcc/gcc/gengtype-lex.l; then \
> > mv -f g-$$ ../../gcc/gcc/gengtype-lex.c ; \
> >else \
> > rm -f g-$$ ; \
> > false ; \
> >fi
> >flex: can't open g-16194
> >
> >on i686-pc-linux-gnu.
> >
> >There are also a bunch of testsuite regressions on hppa64-hp-hpux11.11.
> >
> >Dave
> > 
> >
> This seems to be caused by:
> 
> http://gcc.gnu.org/ml/gcc-patches/2003-10/msg00529.html
> 
> Is flex 2.5.4 unsupported?

No, the patch is wrong.
I'll write a patch and commit it as obvious in a few minutes.
Flex doesn't take a space after the -o option.  It must be -ooutput,
not -o output.  Kelley, assuming you tested this - what version
of flex do you use that this worked for you??

-- 
Carlo Wood <carlo@alinoe.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Re: Someone broke bootstrap
  2003-10-08 11:57   ` Carlo Wood
@ 2003-10-08 12:29     ` Carlo Wood
  2003-10-08 12:43       ` Eric Botcazou
  0 siblings, 1 reply; 6+ messages in thread
From: Carlo Wood @ 2003-10-08 12:29 UTC (permalink / raw)
  To: David Ayers, gcc, kcook34, gcc-patches

On Wed, Oct 08, 2003 at 01:57:45PM +0200, Carlo Wood wrote:
> > Is flex 2.5.4 unsupported?
> 
> No, the patch is wrong.
> I'll write a patch and commit it as obvious in a few minutes.
> Flex doesn't take a space after the -o option.  It must be -ooutput,
> not -o output.  Kelley, assuming you tested this - what version
> of flex do you use that this worked for you??

Commit done as obvious.
http://gcc.gnu.org/ml/gcc-cvs/2003-10/msg00283.html

Tested with 2.5.4a and 2.5.31.  Note that 2.5.31 accepts both '-ooutput'
as well as '-o output', hence the mistake that Kelley made I assume.

-- 
Carlo Wood <carlo@alinoe.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Re: Someone broke bootstrap
  2003-10-08 12:29     ` [PATCH] " Carlo Wood
@ 2003-10-08 12:43       ` Eric Botcazou
  2003-10-08 12:57         ` Carlo Wood
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Botcazou @ 2003-10-08 12:43 UTC (permalink / raw)
  To: Carlo Wood; +Cc: David Ayers, gcc, kcook34, gcc-patches

> Commit done as obvious.
> http://gcc.gnu.org/ml/gcc-cvs/2003-10/msg00283.html

You should post the patch to gcc-patches anyway.

> Log message:
>        * Makefile.in (gengtype-lex.c): flex 2.5.4[a] doesn't understand
>        a space after the -o option.  flex 2.5.31 understands both, with
>        and without the space. Removed that space.

ChangeLog entries should contain the What, not the Why. Use comments in the 
code to record the Why if necessary.

-- 
Eric Botcazou

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Re: Someone broke bootstrap
  2003-10-08 12:43       ` Eric Botcazou
@ 2003-10-08 12:57         ` Carlo Wood
  0 siblings, 0 replies; 6+ messages in thread
From: Carlo Wood @ 2003-10-08 12:57 UTC (permalink / raw)
  To: Eric Botcazou; +Cc: gcc

On Wed, Oct 08, 2003 at 02:45:35PM +0200, Eric Botcazou wrote:
> > Commit done as obvious.
> > http://gcc.gnu.org/ml/gcc-cvs/2003-10/msg00283.html
> 
> You should post the patch to gcc-patches anyway.
> 
> > Log message:
> >        * Makefile.in (gengtype-lex.c): flex 2.5.4[a] doesn't understand
> >        a space after the -o option.  flex 2.5.31 understands both, with
> >        and without the space. Removed that space.
> 
> ChangeLog entries should contain the What, not the Why. Use comments in the 
> code to record the Why if necessary.

Ok, sorry and thanks, I'l remember that for next time.

-- 
Carlo Wood <carlo@alinoe.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-10-08 12:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-08  2:47 Someone broke bootstrap John David Anglin
2003-10-08 10:15 ` David Ayers
2003-10-08 11:57   ` Carlo Wood
2003-10-08 12:29     ` [PATCH] " Carlo Wood
2003-10-08 12:43       ` Eric Botcazou
2003-10-08 12:57         ` Carlo Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).