public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
To: Geoff Keating <geoffk@geoffk.org>
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: [tree-ssa] Garbage collector x bb annotations
Date: Wed, 08 Oct 2003 21:37:00 -0000	[thread overview]
Message-ID: <20031008213722.GA22848@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <jmoewrza7x.fsf@desire.geoffk.org>

Hello,

> > > > I have just run into the following problem: dom_children get released by
> > > > ggc_collect call in tree-ssa-pre.  Allocating them by ggc seems wrong to
> > > > me, since basic block annotations are allocated from obstack and
> > > > invisible to garbage collector.
> > > > 
> > > Yeah.  But there's more than that, unfortunately.  All the fields in
> > > struct bb_ann_d are ggc allocated.  The real solution would be to
> > > finally convert basic blocks to ggc.  Volunteers?
> > 
> > I may try (I need it anyway for tree-ssa-cfg branch).  The whole issue
> > is however quite ugly as this combines basically all allocation
> > mechanisms that are available in gcc (basic blocks themselves are pool
> > allocated).
> 
> It's not that ugly to make the fix, you simply have to throw out all
> those other allocation mechanisms and use ggc.

that's not really a good idea.  Their purpose is to improve data
locality, and changing this would slow down things.

Zdenek

  reply	other threads:[~2003-10-08 21:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-06 22:31 Zdenek Dvorak
2003-10-07  2:53 ` Daniel Berlin
2003-10-08 13:27 ` Diego Novillo
2003-10-08 13:53   ` Zdenek Dvorak
2003-10-08 14:02     ` Diego Novillo
2003-10-08 14:17     ` Daniel Berlin
2003-10-08 21:30       ` Geoff Keating
2003-10-08 22:34         ` Daniel Berlin
2003-10-08 22:49           ` Geoff Keating
2003-10-09 14:42       ` Zdenek Dvorak
2003-10-08 21:32     ` Geoff Keating
2003-10-08 21:37       ` Zdenek Dvorak [this message]
2003-10-08 22:58         ` Geoff Keating
2003-10-08 23:01           ` Daniel Berlin
2003-10-09  0:03             ` David Edelsohn
2003-10-08 23:05           ` Zdenek Dvorak
2003-10-08 23:10             ` Daniel Berlin
2003-10-08 23:12               ` Zdenek Dvorak
2003-10-09  3:31               ` Jeff Sturm
2003-10-08 13:58 S. Bosscher
2003-10-08 14:03 ` Diego Novillo
2003-10-08 14:03 S. Bosscher
2003-10-08 14:19 ` Daniel Berlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031008213722.GA22848@atrey.karlin.mff.cuni.cz \
    --to=rakdver@atrey.karlin.mff.cuni.cz \
    --cc=gcc@gcc.gnu.org \
    --cc=geoffk@geoffk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).